139335 - QA and Debug menu items should be removed for the 1.0 final release

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Daniel (Leaf) Nunes]

The QA and Debug menu items ought to be removed for the 1.0 final release;
assigning to User Interface Design because this is pretty visible UI, but the
patch isn't rocket science.

Comment 1

[Daniel (Leaf) Nunes]

taking.

Comment 2

[Daniel (Leaf) Nunes]

Attachment: this is from mozilla/build/package/rpm/SOURCES/mozilla-navigator-overlay-menu.patch, thanks blizzard :)

this removes debug and qa from navigator; i'll be stealing blizzard's other
patches for editor and mailnews presently.

Comment 3

[Daniel (Leaf) Nunes]

Attachment: editor menu surgery

Comment 4

[Daniel (Leaf) Nunes]

Attachment: the debug prefs in the preferences ui; this is more optional, but a possibility for the final release

Comment 5

[timeless]

asa??

Comment 6

[Zach Lipton [:zach]]

cc'ing mpt on this to keep him in the loop (sorry to comment on a cc)

Comment 7

[Dawn Endico]

The qa and debug menus should be removed from the mozilla1.0 release branch.

The 1.0 release branch is supposed to something from which people can pull
to make a releasable product and don't want others to include our debug or
qa menus. I don't want the menus even in our own mozilla 1.0 builds.

I'm not suggesting that these menus be removed from daily builds or
from regular milestones, only from the actual blessed 1.0 builds. These
builds are going to get a LOT of press. RC1 already had an article in
Time magazine. We want these people to use mozilla for the talkback data
but only a tiny fraction of them would find anything in the debug or qa
menus useful. Let them get a nightly build.

Out of curiosity a lot of time magazine readers will hit the 'bugs
filed today' and 'cvs checkins today' menu items. We cannot handle the server
load of a million curious users. The start page is the proper place to 
evangelize new recruits and people who really do want to debug should be
using other builds.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does the commercial tree remove these by overlay?  If so, I'm assuming leaf will
make the necessary commercial changes (if any -- I'm not sure if any really are).

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

We need r/sr for these; please beat up the right people for r/sr.  We need to
disable/remove them from 1.0 official builds.  Adding dependency on RC2 Not Suck

Comment 10

[Asa Dotzler [:asa]]

This makes me sad. I can see the problem with the bugzilla and bonsai queries in
the QA menu leading to performance problems in our tool suite but the rest of
menus serve a good purpose of providing easy access to the tools for testers and
don't cost us. Our releases/index.html says "We make binary versions of Mozilla
available for testing purposes only!" and removing access points for testing our
test binaries seems wrong. 

Comment 11

[Dawn Endico]

Yes, but that doesn't mean that everyone has to do each test.
With a mega-release like 1.0 we should be happy to get lots of
talkback data and not annoy people with a lot of extra crap
which makes them send whiney or desperate or desperate (xul
boxes) mail to webmaster.

The people who aren't annoyed by the 'extra crap' are already
using regular builds or can be recruited by the start page.
Remember, this is only for 1.0.

Comment 12

[Ben Bucksch (:BenB)]

If you remove the stuff, commenting it out should be enough.
That's what's usually been done on the Netscape branches, e.h., the
point-release branches. (Although it annoys me, as I always comment the stuff
out, too, and I get merge conflicts all the time.)

Comment 13

[timeless]

i think a dynamic overlay would be more correct. then releases could not make 
the reference for it. although there's a minor perf hit..

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

r=ben on these patches. Commercial hides these with a stylesheet, but it won't
be negatively affected as the removal of the items will cause the rules in the
stylesheets not to match, which has no effect. 

Comment 15

[Asa Dotzler [:asa]]

who can sr= here? Time is short. We need quick turnaoround. Blake? Hewitt?

Comment 16

[Joe Hewitt (gone)]

Comment on attachment 80501 [details] [diff] [review]
the debug prefs in the preferences ui; this is more optional, but a possibility for the final release

sr=hewitt

Comment 17

[Joe Hewitt (gone)]

Comment on attachment 80500 [details] [diff] [review]
editor menu surgery

sr=hewitt

Comment 18

[Joe Hewitt (gone)]

Comment on attachment 80499 [details] [diff] [review]
this is from mozilla/build/package/rpm/SOURCES/mozilla-navigator-overlay-menu.patch, thanks blizzard :)

sr=hewitt

Comment 19

[Brian McGroarty]

would rather see this as a command-line option or similar, defaulting to off in
release. fewer functionality changes between debug/release are good.

Comment 20

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 80499 [details] [diff] [review]
this is from mozilla/build/package/rpm/SOURCES/mozilla-navigator-overlay-menu.patch, thanks blizzard :)

marking r=ben on patches per his comment

Comment 21

[Mark Bitterling]

I have mixed emotions about the removal of the Debug and QA menus, but oh well.

However, I do have a question.

If the decision is to remove the menus, then do the various sample and test
files (ie the samples directory) also get removed?  Is there any reason to
include them when the menus are gone?  I realize it is only about 1MB or so
uncompressed, but if millions of downloads are anticipated...

Comment 22

[Christian :Biesinger (don't email me, ping me on IRC)]

>If you remove the stuff, commenting it out should be enough.

Why not remove it, leaving it in serves no purpose.
And why not use a stylesheet as somebody suggested here?


Though I personally am against this, and so is Asa, apparently. Especially the
QA menu contains useful links, for me at least, and for other people interested
in testing Mozilla.

Comment 23

[Andrew Hagen]

There are going to be a bunch of novice users who download 1.0. They won't be
able to contribute to QA anyway. Thus, I'd say take these menus out for the 1.0
release only.

Comment 24

[Pete Boyd]

is it proposed to remove Debug and QA menus from 1.0.x or just 1.0.0? reading
this bug, it appears to just be 1.0.0. and if its done for 1.0.x, what of 1.1.0
once the precident is set?

Comment 25

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

asa, cbiesinger: 
The Debug and QA menus contain bookmark-like items. IMO, those items would fit
better in the default bookmarks. (I think it makes sense to remove the Debug and
QA menus.)

Comment 26

[Asa Dotzler [:asa]]

last minute changes ->RC3.

Comment 27

[Håkan Waara]

Do we have an official a=drivers here, and if so, can someone go ahead and check
the patch into the branch?

Comment 28

[Christian :Biesinger (don't email me, ping me on IRC)]

hwaara, read comment 11... only the exact 1.0 release will have this removed, no
other build.

Comment 29

[chris hofmann]

Comment on attachment 80501 [details] [diff] [review]
the debug prefs in the preferences ui; this is more optional, but a possibility for the final release

a=chofmann, leaf do the deed and lets get this off the list. thx

Comment 30

[Daniel (Leaf) Nunes]

menus whacked. editor menus had been commented out already (i commented out one
last reference that brade didn't comment out).

Comment 31

[Asa Dotzler [:asa]]

housekeeping: adding branch resolution keyword.