Closed Bug 1393468 Opened 7 years ago Closed 7 years ago

Update webrender to b7cec8b19d5d6061263c3639031caf41562a2e17

Categories

(Core :: Graphics: WebRender, defect, P3)

57 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1391614 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90e4d8bbd22f510c46c8348681d2f8ff4574c2a4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2a9fc233183a2e8f8806216d12c093ed083a43f

Busted. Regression range: 

*   2ac2da08 Auto merge of #1613 - glennw:clip-mask-opt, r=kvark
|\
| * 5a63bfe2 When creating a clip mask, only include relevant masks.
*   d83fc450 Auto merge of #1609 - nical:reset-state, r=glennw
|\
| * 615b74a0 Reset cached gl state after calling into external image hooks.
*   dd11229d Auto merge of #1600 - glennw:batching, r=kvark
|\
| * edf1cd23 Refactor and small optimization of batching code.
|/
* 301b67da Auto merge of #1594 - kvark:profile, r=glennw
* 460a1ae9 Sample coverage profiling metrics
Looks like probably from 460a1ae9 which made renderer not pub? kvark, can you take a look and provide a patch? Thanks.
Flags: needinfo?(kvark)
Kats,

The patch is fairly trivial:

diff --git a/gfx/webrender_bindings/src/bindings.rs b/gfx/webrender_bindings/src/bindings.rs
index 758e8945bf71..e2f41dccc1b6 100644
--- a/gfx/webrender_bindings/src/bindings.rs
+++ b/gfx/webrender_bindings/src/bindings.rs
@@ -7,9 +7,9 @@ use std::os::raw::{c_void, c_char, c_float};
 use gleam::gl;
 
 use webrender_api::*;
-use webrender::renderer::{ReadPixelsFormat, Renderer, RendererOptions};
-use webrender::renderer::{ExternalImage, ExternalImageHandler, ExternalImageSource};
-use webrender::renderer::DebugFlags;
+use webrender::{ReadPixelsFormat, Renderer, RendererOptions};
+use webrender::{ExternalImage, ExternalImageHandler, ExternalImageSource};
+use webrender::DebugFlags;
 use webrender::{ApiRecordingReceiver, BinaryRecorder};
 use thread_profiler::register_thread_with_profiler;
 use moz2d_renderer::Moz2dImageRenderer;

I can't push to try atm because my HG access was revoked due to inactivity. I'm in process to getting it back now.
Flags: needinfo?(kvark)
Thanks, I'll add it to my patch queue.
WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 could fix the bug 1376213.
(In reply to Jerry Shih[:jerry] (UTC+8) from comment #9)
> WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 could fix the bug 1376213.

Sounds good, I'll get the update landed.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to b7cec8b19d5d6061263c3639031caf41562a2e17
Version: unspecified → 57 Branch
No longer depends on: 1393055
Attachment #8901801 - Flags: review?(jmuizelaar)
Comment on attachment 8901803 [details]
Bug 1393468 - Fix for changes in WR cset 460a1ae9.

https://reviewboard.mozilla.org/r/173246/#review178606
Attachment #8901803 - Flags: review?(bugmail) → review+
Comment on attachment 8901801 [details]
Bug 1393468 - Regenerate FFI bindings header.

https://reviewboard.mozilla.org/r/173242/#review178608
Attachment #8901801 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8901802 [details]
Bug 1393468 - Update webrender to commit b7cec8b19d5d6061263c3639031caf41562a2e17.

https://reviewboard.mozilla.org/r/173244/#review178610
Attachment #8901802 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8901803 [details]
Bug 1393468 - Fix for changes in WR cset 460a1ae9.

https://reviewboard.mozilla.org/r/173246/#review178612
Attachment #8901803 - Flags: review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/155bf5fa3789
Regenerate FFI bindings header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6ebece3e7f30
Update webrender to commit b7cec8b19d5d6061263c3639031caf41562a2e17. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/201c0c94bae0
Fix for changes in WR cset 460a1ae9. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: