Closed
Bug 1393468
Opened 7 years ago
Closed 7 years ago
Update webrender to b7cec8b19d5d6061263c3639031caf41562a2e17
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
+++ This bug was initially created as a clone of Bug #1391614 +++ I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages. When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update". [1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Comment 1•7 years ago
|
||
WR @ 1a5129396ad2fe9e34ff9ebae203d0119558b261 https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6bc5cac5e45aca0f52a30b352d00e297ccb7b41 https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d8a8ffcd59d5ed6c2e9da374ffc504aed9a5013 Green so far.
Assignee | ||
Comment 2•7 years ago
|
||
WR @ 8c94ee748031d7fb15b6f1972df5edfcea0af29d https://treeherder.mozilla.org/#/jobs?repo=try&revision=926747fad6f567f1ed22f577967bb4b2b6c82b0b https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c23ab8a15e08078e07096c1a692aabb7b68b663 Green
Assignee | ||
Comment 3•7 years ago
|
||
WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 https://treeherder.mozilla.org/#/jobs?repo=try&revision=90e4d8bbd22f510c46c8348681d2f8ff4574c2a4 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2a9fc233183a2e8f8806216d12c093ed083a43f Busted. Regression range: * 2ac2da08 Auto merge of #1613 - glennw:clip-mask-opt, r=kvark |\ | * 5a63bfe2 When creating a clip mask, only include relevant masks. * d83fc450 Auto merge of #1609 - nical:reset-state, r=glennw |\ | * 615b74a0 Reset cached gl state after calling into external image hooks. * dd11229d Auto merge of #1600 - glennw:batching, r=kvark |\ | * edf1cd23 Refactor and small optimization of batching code. |/ * 301b67da Auto merge of #1594 - kvark:profile, r=glennw * 460a1ae9 Sample coverage profiling metrics
Assignee | ||
Comment 4•7 years ago
|
||
Looks like probably from 460a1ae9 which made renderer not pub? kvark, can you take a look and provide a patch? Thanks.
Flags: needinfo?(kvark)
Comment 5•7 years ago
|
||
Kats, The patch is fairly trivial: diff --git a/gfx/webrender_bindings/src/bindings.rs b/gfx/webrender_bindings/src/bindings.rs index 758e8945bf71..e2f41dccc1b6 100644 --- a/gfx/webrender_bindings/src/bindings.rs +++ b/gfx/webrender_bindings/src/bindings.rs @@ -7,9 +7,9 @@ use std::os::raw::{c_void, c_char, c_float}; use gleam::gl; use webrender_api::*; -use webrender::renderer::{ReadPixelsFormat, Renderer, RendererOptions}; -use webrender::renderer::{ExternalImage, ExternalImageHandler, ExternalImageSource}; -use webrender::renderer::DebugFlags; +use webrender::{ReadPixelsFormat, Renderer, RendererOptions}; +use webrender::{ExternalImage, ExternalImageHandler, ExternalImageSource}; +use webrender::DebugFlags; use webrender::{ApiRecordingReceiver, BinaryRecorder}; use thread_profiler::register_thread_with_profiler; use moz2d_renderer::Moz2dImageRenderer; I can't push to try atm because my HG access was revoked due to inactivity. I'm in process to getting it back now.
Flags: needinfo?(kvark)
Assignee | ||
Comment 6•7 years ago
|
||
Thanks, I'll add it to my patch queue.
Assignee | ||
Comment 7•7 years ago
|
||
I started a try push with that applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da7126d26fb301a020ebe391c5798f1de6a5f12a
Assignee | ||
Comment 8•7 years ago
|
||
WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 (with fix) https://treeherder.mozilla.org/#/jobs?repo=try&revision=77e2ea952b32ab7c91ce1c596015fafaea4d1028 https://treeherder.mozilla.org/#/jobs?repo=try&revision=12ed2551d717dfd47fb77e8fcd2196bbf00ab767 Green
Comment 9•7 years ago
|
||
WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 could fix the bug 1376213.
Assignee | ||
Comment 10•7 years ago
|
||
WR @ 56f75e785bd2b641e06b52adc9513c04516b1b80 https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a11fc4cf843b53e065d9abda108bf51b648257d https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c753e36d5a9c42c1440a5c2fdf8cce9e8c02bb1 plus more pushes over the weekend, all green. WR @ 95a4ba0fb673091f7258d929bd2091e629f1c475 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7ebcb3aed2fd8b9af6f2e336f870df83dfbe7e3 https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba23462f23089c9d2d6ef7dc3e96072db28f3e77 Green WR @ b7cec8b19d5d6061263c3639031caf41562a2e17 https://treeherder.mozilla.org/#/jobs?repo=try&revision=1574854f7c5fdd8b97ef8ab5160febaee8f0a853 https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf3daf0b41ba65c1c5dc865701688cd98ba6a68 Green
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Jerry Shih[:jerry] (UTC+8) from comment #9) > WR @ 2ac2da08b77aff15cc7e38118fa20071262b07e9 could fix the bug 1376213. Sounds good, I'll get the update landed.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to b7cec8b19d5d6061263c3639031caf41562a2e17
Version: unspecified → 57 Branch
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8901801 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8901803 [details] Bug 1393468 - Fix for changes in WR cset 460a1ae9. https://reviewboard.mozilla.org/r/173246/#review178606
Attachment #8901803 -
Flags: review?(bugmail) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8901801 [details] Bug 1393468 - Regenerate FFI bindings header. https://reviewboard.mozilla.org/r/173242/#review178608
Attachment #8901801 -
Flags: review?(jmuizelaar) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8901802 [details] Bug 1393468 - Update webrender to commit b7cec8b19d5d6061263c3639031caf41562a2e17. https://reviewboard.mozilla.org/r/173244/#review178610
Attachment #8901802 -
Flags: review?(jmuizelaar) → review+
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8901803 [details] Bug 1393468 - Fix for changes in WR cset 460a1ae9. https://reviewboard.mozilla.org/r/173246/#review178612
Attachment #8901803 -
Flags: review+
Comment 19•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/155bf5fa3789 Regenerate FFI bindings header. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/6ebece3e7f30 Update webrender to commit b7cec8b19d5d6061263c3639031caf41562a2e17. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/201c0c94bae0 Fix for changes in WR cset 460a1ae9. r=jrmuizel
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/155bf5fa3789 https://hg.mozilla.org/mozilla-central/rev/6ebece3e7f30 https://hg.mozilla.org/mozilla-central/rev/201c0c94bae0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•