Closed
Bug 1393487
Opened 7 years ago
Closed 7 years ago
Spurious unused variable warning due to _alloca hack
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
This hack causes several unused variable warnings. Let's silence them?
http://searchfox.org/mozilla-central/source/dom/plugins/base/PluginPRLibrary.cpp#19
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tom
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
That was a bad try run because it depends on a bug I forgot about. New try run with both patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee870e874730a70b9e889bf4ffb8f100ab50628b
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp
https://reviewboard.mozilla.org/r/172216/#review178830
I'm not a NPAPI plugin peer, so redirecting this review to jimm, who's guilty of reviewing such patches in the past.
Updated•7 years ago
|
Attachment #8900770 -
Flags: review?(cpearce) → review?(jmathies)
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp
https://reviewboard.mozilla.org/r/172216/#review179724
Attachment #8900770 -
Flags: review?(jmathies) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2656d6b44fc
Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp r=jimm
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•