1393487 - Spurious unused variable warning due to _alloca hack

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Tom Ritter [:tjr]]

This hack causes several unused variable warnings. Let's silence them?

http://searchfox.org/mozilla-central/source/dom/plugins/base/PluginPRLibrary.cpp#19

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp

Review commit: https://reviewboard.mozilla.org/r/172216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172216/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172216/diff/1-2/

Comment 3

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=edbc27d42e5e10db98b290693877a04fb83d1b1e

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172216/diff/2-3/

Comment 5

[Tom Ritter [:tjr]]

That was a bad try run because it depends on a bug I forgot about. New try run with both patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee870e874730a70b9e889bf4ffb8f100ab50628b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp

https://reviewboard.mozilla.org/r/172216/#review178830

I'm not a NPAPI plugin peer, so redirecting this review to jimm, who's guilty of reviewing such patches in the past.

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8900770 [details]
Bug 1393487 Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp

https://reviewboard.mozilla.org/r/172216/#review179724

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2656d6b44fc
Silence unused variable warning because we do it on purpose in PluginPRLibrary.cpp r=jimm

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a2656d6b44fc