Change default bookmark from /firefox/desktop/customize to SUMO article

RESOLVED FIXED in Firefox 61

Status

()

Firefox
Bookmarks & History
P3
normal
RESOLVED FIXED
9 months ago
2 months ago

People

(Reporter: hoosteeno, Assigned: Alex Morega, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 61
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional, firefox61 fixed)

Details

(Whiteboard: [lang=html])

Attachments

(1 attachment)

In bug 1393243 we are decommissioning the content at https://www.mozilla.org/firefox/desktop/customize/. This URL is among the default bookmarks the browser ships with. We will redirect visitors to that URL to the content we've selected to replace it (https://support.mozilla.org/kb/customize-firefox-controls-buttons-and-toolbars), but we should change that bookmark to keep things tidy.

Code is here:
https://dxr.mozilla.org/mozilla-central/source/browser/locales/generic/profile/bookmarks.html.in#37

Question:
* Would it be appropriate to include UTM parameters on these links to help attribute traffic coming from default bookmarks? If so I can provide.
Mentor: mak77
status-firefox57: --- → fix-optional
Priority: -- → P3

Updated

3 months ago
Keywords: good-first-bug

Comment 1

3 months ago
Hi, I'm new to Bugzilla and would like to work on this bug.

Comment 2

3 months ago
Did you already go through https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction and do you have a local build (even an artifact build will be fine) working?

Comment 3

3 months ago
(In reply to Marco Bonardo [::mak] from comment #2)
> Did you already go through
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Introduction and do you have a local build (even an artifact build will be
> fine) working?

I've read the guide and have a build working!

Comment 4

3 months ago
OK, you can look for bookmarks.html.in, there is a link
https://www.mozilla.org/@AB_CD@/firefox/customize/
that should be changed to
https://support.mozilla.org/@AB_CD@/kb/customize-firefox-controls-buttons-and-toolbars

then you can rebuild the browser, run it on a new profile and check the link in the Firefox folder in the bookmarks menu, it should point to the new url.
Since we're talking about implementation, I'd like to return to the question from comment 0:

> Question: Would it be appropriate to include UTM parameters on these links to help attribute traffic coming from default bookmarks? If so I can provide.

We have many links in the browser product with UTM parameters[0], and default bookmarks in android include such parameters[1]. :julikatd (or whoever implements), if nobody follows up with a reason not to include such parameters, would you please use the following URL for the default bookmark? The link text itself can remain unchanged.

https://support.mozilla.org/kb/customize-firefox-controls-buttons-and-toolbars?utm_source=firefox-browser&utm_medium=default-bookmarks&utm_campaign=customize

---

[0] https://dxr.mozilla.org/mozilla-central/search?q=utm_source
[1] https://dxr.mozilla.org/mozilla-central/search?q=utm_source+bookmarkdefault&redirect=false

Comment 6

3 months ago
(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #5)
> > Question: Would it be appropriate to include UTM parameters on these links to help attribute traffic coming from default bookmarks? If so I can provide.

The best persons to answer this questions is people working on tracking our sites usage.

> if nobody follows up with a reason not to include such
> parameters, would you please use the following URL for the default bookmark?
> The link text itself can remain unchanged.
> 
> https://support.mozilla.org/kb/customize-firefox-controls-buttons-and-
> toolbars?utm_source=firefox-browser&utm_medium=default-
> bookmarks&utm_campaign=customize

plus the language tag (@AB_CD@).
I don't have anything against that, but I don't use that info, so I don't even have anything in favor of it. It should cost us anything to add them.

Comment 7

3 months ago
s/anything/nothing/
> The best persons to answer this questions is people working on tracking our sites usage.

That's me! Let's do it.
Whiteboard: [lang=html

Comment 10

3 months ago
Hi, I have a question about testing this. When I rebuild in mozilla-central, then run './mach run -P' and create a new profile, I get the Nightly related default links. What step am I missing to display the other default links?
(In reply to julikatd from comment #10)
> Hi, I have a question about testing this. When I rebuild in mozilla-central,
> then run './mach run -P' and create a new profile, I get the Nightly related
> default links. What step am I missing to display the other default links?

The easiest way I found recently was to temporarily change the ifndef NIGHTLY_BUILD to ifdef NIGHTLY_BUILD, and then rebuild.
(Assignee)

Comment 12

2 months ago
Created attachment 8962158 [details] [diff] [review]
Change URL for "customize" bookmark

Here's a patch to fix this bug. It's my first attempt at contributing to Mozilla :)
Comment on attachment 8962158 [details] [diff] [review]
Change URL for "customize" bookmark

Review of attachment 8962158 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for posting the patch Alex, it looks good. r=Standard8. I'll set some flags to get this landed in the tree.
Attachment #8962158 - Flags: review+
Info for Sheriffs: this is a simple url change in an html file tested locally, a try server build shouldn't be necessary.
Assignee: nobody → alex
Status: NEW → ASSIGNED
Keywords: checkin-needed

Updated

2 months ago
Mentor: mak77 → standard8

Comment 15

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/330dc2385e33
Change default bookmark from /firefox/desktop/customize to SUMO article. r=Standard8
Keywords: checkin-needed

Comment 16

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/330dc2385e33
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.