1393896 - nrappkit uses incorrect preprocessor flags to detect Windows

Status: RESOLVED INCOMPLETE

(Core :: WebRTC, enhancement, P3)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

In our patch on top of nrappkit, Windows is detected for header including using #ifndef _MSC_VER - this is incorrect (as it breaks the MinGW build). The correct directive to use is WIN32.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1393896 Detect Windows using WIN32 instead of _MSC_VER which is not set under MinGW

Review commit: https://reviewboard.mozilla.org/r/172740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172740/

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Last time I tried building WebRTC I did not get the same errors. I'm resolving the sub-bugs as Incomplete until I can go back to building WebRTC and if they are still applicable, I'll reopen.