1393901 - --enable-webrtc does not build under MinGW

Status: NEW

(Core :: WebRTC, enhancement, P5)

Description

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

This is a tracking bug

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.

Comment 2

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: Bug 1393901 Enable WebRTC for the MinGW build

Review commit: https://reviewboard.mozilla.org/r/194148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194148/

Comment 3

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Alex from Waterfox was able to get WebRTC building under mingw-clang. I've reproduced it locally. He reported "Unfortunately it appears networking itself doesn't work - but microphone, webcam do."

I'd like to try and get his patches landed even if the functionality needs debugging, so we don't regress on this awesome achievement.

Presently there are two components here: one is a set of patches to Firefox; and the second is a set of patches to mingw/clang. The latter set of patches are more workarounds that need a better solution, so I'll be exploring that.

Comment 4

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: Bug 1393901: Local OS_LIBS capitalization fixes r?dminor

Comment 5

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: WIP: Bug 1393901: Upstream capitalization fixes

Depends on D125142

Comment 6

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: WIP: Bug 1393901: WIP!!! Everything else

Depends on D125143

Comment 7

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Dan are you the best person to provide (initial) review/guidance on these patches? I'd like to land the first (OS_LIBS) one now; and I'd like your feedback on the second one fixing capitalization upstream. Where would I submit that patch upstream and what would be the process? (And how would I land fixes in the mozilla tree such that landing it upstream doesn't cause a problem when we want to update?)

Comment 8

[Dan Minor [:dminor]]

I'm not working on WebRTC right now, I think Nico would be the best person to help you with this, he's currently leading a libwebrtc update project.

Comment 9

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Progress update: I've refactored all the compiler changes out into Firefox changes and have a working x64 build. Continuing cleanup and will work on x86 also.

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Tom, the moz.build files under libwebrtc should not be manually edited. There are accompanying BUILD.gn files that need to be changed and then the moz.build files need to be regenerated. It is best to use two different patches, one for the BUILD.gn fixes and one for the moz.build regenerations. We are in the middle of the next libwebrtc merge-in, Bug 1654112, and have developed a script to make that process easier for us, it may not work on moz-central but it should give you a good idea of what needs to be done. Check the README.md file for details, https://hg.mozilla.org/users/na-g_nostrum.com/libwebrtc-merge-2H2020/file/tip/dom/media/webrtc/third_party_build/gn-configs . You can also try your changes on the libwebrtc merge branch. I will note that the Strmiids.h -> strmiids.h issue seems to already be fixed in the version that we have vendored into the merge branch.

Some digging in the upstream repository revealed the following patch https://webrtc-review.googlesource.com/c/src/+/64762/ for lower casing the library names on Windows.