1394117 - Selection for webextension themes is not preserved if extensions DB is lost

Status: RESOLVED DUPLICATE of bug 1448221

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Andrew Swan [:aswan]]

There are a bunch of tests that covers rebuilding the addons database in various scenarios (listed below).  With complete themes, the currently selected theme was preserved across a database rebuild.  When webextension themes were added, these tests were never changed/extended to check that the same was true for them.  As part of bug 1369517 I tried just switching the tests from complete themes to webextension themes and a bunch of tests broke but I don't have time to dig into this right now.  These tests (from toolkit/mozapps/extensions/test/xpshell) should be updated to work properly with webextension themes:

test_badschema.js
test_corrupt.js
test_corrupt_strictcompat.js
test_locked.js
test_locked_strictcompat.js

Comment 1

[Mike de Boer [:mikedeboer]]

Ah! Thanks for finding & filing this, Andrew!

Comment 2

[Andy McKay]

Should this be higher than P5 Andrew?

Comment 3

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #2)
> Should this be higher than P5 Andrew?

I'm not sure, I should have mentioned in the original report that this could well just be an issue with the way the tests are written.  But even if the underlying thing isn't broken and this is a test-only issue, we should still get our test coverage in place.  That said, rebuilding the database due to corruption should be an uncommon event and losing your theme selection is annoying but hardly catastrophic.

Comment 4

[Mike de Boer [:mikedeboer]]

Unassigning myself to reflect current status; still working lots on Photon atm.