1369517 - Ensure that everything in automation can run with MOZ_ENABLE_LEGACY_EXTENSIONS=false

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Andrew Swan [:aswan]]

With bug 1363897 we will build beta and release with support for legacy extensions disabled at build time.  This bug is to track all the things we need to do in automated tests of all varieties to prepare for that.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1369517 Make automation work with legacy extensions disabled

- Set the extensions.legacy.enabled pref for mochitests etc
- Skip a plugin-inside-xpi test for now if legacy extensions
  are force-disabled.  That test can just be removed once we
  get to 57.

Review commit: https://reviewboard.mozilla.org/r/152396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152396/

Comment 2

[Andrew Swan [:aswan]]

Here is a try run with the attached patch and with legacy extensions disabled at build time:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7105ca2bde5f7bba2625f6a4b7a470d4f14b6416

The Fxfn failures are bug 1360687 (nudge :whimboo) and I didn't run Talos since that still isn't working (bug 1361002).  But overall, looking good.

(and when bug 1363897 lands we'll be able to disable legacy extensions in a more graceful way, and more importantly, in a way that it will happen automatically when sheriffs do their regular beta simulation builds)

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8881055 [details]
Bug 1369517 Make automation work with legacy extensions disabled

https://reviewboard.mozilla.org/r/152396/#review157538

::: python/mozbuild/mozbuild/mozinfo.py:93
(Diff revision 1)
>      d['telemetry'] = substs.get('MOZ_TELEMETRY_REPORTING') == '1'
>      d['tests_enabled'] = substs.get('ENABLE_TESTS') == "1"
>      d['bin_suffix'] = substs.get('BIN_SUFFIX', '')
>      d['addon_signing'] = substs.get('MOZ_ADDON_SIGNING') == '1'
>      d['require_signing'] = substs.get('MOZ_REQUIRE_SIGNING') == '1'
> +    d['no_legacy_extensions'] = substs.get('MOZ_ALLOW_LEGACY_EXTENSIONS') == '0'

Hm so this says `no_legacy_extensions` but xpcshell.ini has `!legacy_extensions`... should this  be `legacy_extensions (...) == '1'` or am I missing something about how this works?

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8881055 [details]
Bug 1369517 Make automation work with legacy extensions disabled

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152396/diff/1-2/

Comment 5

[Robert Helmer [:rhelmer]]

Comment on attachment 8881055 [details]
Bug 1369517 Make automation work with legacy extensions disabled

https://reviewboard.mozilla.org/r/152396/#review157682

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94dcf7784bd0
Make automation work with legacy extensions disabled r=rhelmer

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94dcf7784bd0

Comment 8

[Andrew Swan [:aswan]]

Unassigning myself since this is a meta-bug.  Also removing the dependency on sync since that's not currently causing failures in automation (thought it would probably still be a good thing to address at some point)

Comment 9

[Andrew Swan [:aswan]]

Ryan, can we close this bug?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I think we're good!

Comment 11

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.