1394489 - support stylo by default and "stylo-disabled" test jobs in AWFY

Status: RESOLVED FIXED

(Testing Graveyard :: AWFY, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

AWFY runs stylo builds in parallel to default builds;  when we switch to stylo as default we will need to set this environment variable for the non-stylo builds:
 STYLO_FORCE_DISABLED=1

ideally the default firefox line will remain the default and the 'stylo' specific line will go away and we will add a new non-stylo specific line.

Comment 1

[Bob Clary [:bc] (inactive)]

opt in stylo was added in bug 1394489. We'll have disable that and add the non-stylo version.

Anyone care to bikeshed? non-stylo vs. gecko vs. ?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I think we are going to use in talos:
non-stylo
or
stylo-disabled

and with stylo will be plain old Firefox.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

For naming, the test and talos jobs that use the Gecko style system after we flip to Stylo by default in bug 1330412 will be labelled "stylo-disabled", so perhaps a similar convention is good here.

Comment 4

[Bob Clary [:bc] (inactive)]

Thanks. Will do. That should have been Bug 1392123 and not a circular reference, btw.

Comment 5

[Bob Clary [:bc] (inactive)]

In bug 1390206 <https://github.com/mozilla/arewefastyet/commit/71cb9664696776ab45daf3ff6610ac87685f56a2> we explicily disabled stylo on the default configuration. I wonder if I should explicitly force it on to prevent experiments or other transient changes from disabling it as we go forward.

Should I wait for the default to change to stylo enabled before making this change or could I force stylo on in the default config at the same time that I disable stylo in the stylo-disabled config and deploy this before stylo becomes default?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Bob Clary [:bc:] from comment #5)
> In bug 1390206
> <https://github.com/mozilla/arewefastyet/commit/
> 71cb9664696776ab45daf3ff6610ac87685f56a2> we explicily disabled stylo on the
> default configuration. I wonder if I should explicitly force it on to
> prevent experiments or other transient changes from disabling it as we go
> forward.

After Stylo is enabled by default, there is no harm in force-enabling it to prevent experiments from silently disabling it. It might be a good idea to do when we add the stylo-disabled config.

> Should I wait for the default to change to stylo enabled before making this
> change or could I force stylo on in the default config at the same time that
> I disable stylo in the stylo-disabled config and deploy this before stylo
> becomes default?

I'm not sure I understand the question, but we don't need to force-enable Stylo in the default config yet. You could write the code to add the stylo-disabled config before we need to run it, if that saves you time. But you don't need to deploy it before we enable Stylo by default.

Comment 7

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/172

Comment 8

[Bob Clary [:bc] (inactive)]

Attachment: bug-1394489.sql

Comment 9

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/arewefastyet/commit/ee8198470572e394fe0646119b04ec182e1c2819

Comment 10

[Bob Clary [:bc] (inactive)]

Attachment: control_tasks.sql.2017-09-06

Comment 11

[Bob Clary [:bc] (inactive)]

The Win8 Stylo Disabled jobs aren't being scheduled. See bug 1397319

Comment 12

[Bob Clary [:bc] (inactive)]

NI to disable the old Stylo graphs in a few days unless someone wants to keep it.

Comment 13

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/175

Disable firefox_stylo mode to hide graph

Comment 14

[Bob Clary [:bc] (inactive)]

Thanks!

https://github.com/mozilla/arewefastyet/commit/17b3b389ecc415e1fce373ddf3e2fb6e7195d730
and pulled on arewefastyet.com