1394513 - Use the same separator that the photon toolbar is using for the toolbox tab separator

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

For separator lines, use the same separator that the Photon toolbar is using next to the hamburger menu.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1394513 - Part 1: Use the same separator styles as photon for the toolbox tab separator.

Review commit: https://reviewboard.mozilla.org/r/173540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173540/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1394513 - Part 2: Fix the devtools separator styling in the webconsole and make the filter message text unselectable.

Review commit: https://reviewboard.mozilla.org/r/173542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173542/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8902103 [details]
Bug 1394513 - Part 1: Use the same separator styles as photon for the toolbox tab separator.

https://reviewboard.mozilla.org/r/173540/#review179220

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8902104 [details]
Bug 1394513 - Part 2: Fix the devtools separator styling in the webconsole and make the filter message text unselectable.

https://reviewboard.mozilla.org/r/173542/#review179226

::: devtools/client/themes/webconsole.css:787
(Diff revision 1)
>  .webconsole-filterbar-primary .devtools-plaininput {
>    flex: 1 1 100%;
>  }
>  
> +.webconsole-filterbar-secondary .devtools-separator {
> +  height: 100%;

Should height: 100% be folded into the main .devtools-separator styling?  Seems like something that may need to be repeated if it is needed in this case

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a784da121067
Part 1: Use the same separator styles as photon for the toolbox tab separator. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/895ed9cd8d3f
Part 2: Fix the devtools separator styling in the webconsole and make the filter message text unselectable. r=bgrins

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a784da121067
https://hg.mozilla.org/mozilla-central/rev/895ed9cd8d3f