Closed Bug 1394513 Opened 2 years ago Closed 2 years ago

Use the same separator that the photon toolbar is using for the toolbox tab separator

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

For separator lines, use the same separator that the Photon toolbar is using next to the hamburger menu.
See Also: → 1307881
Comment on attachment 8902103 [details]
Bug 1394513 - Part 1: Use the same separator styles as photon for the toolbox tab separator.

https://reviewboard.mozilla.org/r/173540/#review179220
Attachment #8902103 - Flags: review?(bgrinstead) → review+
Comment on attachment 8902104 [details]
Bug 1394513 - Part 2: Fix the devtools separator styling in the webconsole and make the filter message text unselectable.

https://reviewboard.mozilla.org/r/173542/#review179226

::: devtools/client/themes/webconsole.css:787
(Diff revision 1)
>  .webconsole-filterbar-primary .devtools-plaininput {
>    flex: 1 1 100%;
>  }
>  
> +.webconsole-filterbar-secondary .devtools-separator {
> +  height: 100%;

Should height: 100% be folded into the main .devtools-separator styling?  Seems like something that may need to be repeated if it is needed in this case
Attachment #8902104 - Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a784da121067
Part 1: Use the same separator styles as photon for the toolbox tab separator. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/895ed9cd8d3f
Part 2: Fix the devtools separator styling in the webconsole and make the filter message text unselectable. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/a784da121067
https://hg.mozilla.org/mozilla-central/rev/895ed9cd8d3f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.