1394747 - fennec jamun {bncr sub, update monitoring, mark as shipped} fail: No such builder in Buildbot

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

fennec jamun bncr sub fails like at [1]. The error on BBB is:

> Aug 29 01:26:44 buildbot-master84.bb.releng.scl3.mozilla.com python: buildbot_bridge_tclistener bbb.services - task 89-Lz-aZQd6xEbam2mjg9Q: run 0: buildername: release-jamun-fennec_bncr_sub: Payload is invalid (invalid buildername), refusing to create BuildRequest 

Rail said: 
> <rail> it says that there is no such builder in buildbot
> <rail> it uses http://builddata.pub.build.mozilla.org/reports/allthethings/allthethings.json.gz to compare buildernames


My current goal is to test bug 1384482. This bug is not important, in this regard, so I won't tackle it today. However, let's keep track of it, so we have a clean staging release infrastructure. 

[1] https://tools.taskcluster.net/groups/T2TDo_JNTP2LMfneMcHONA/tasks/89-Lz-aZQd6xEbam2mjg9Q/details

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

I looked a bit at this builder as well last night but didn't reach a conclusions yet. 

If you remember last week, we had a conversation about how a mozilla-beta based staging release (instead of jamun) had a green bouncer submission. That wasn't supposed to happen, yet it did because there's no clear separation between prod/staging on buildbot.

Facts:
* bouncer submission job is green on Firefox/Fennec on production
* bouncer submission jos is green for Firefox staging if based on mozilla-beta
* bouncer submission job fails if built against jamun for Fennec

What I think happens is:
* the BB job lies here[1]
* in order to define the BB builder, it needs to grab some configs from bbconfigs. If this was production, all the stuff was brought from config.py (e.g. [2]). If we look for jamun, we see that's missing from its configs[3].
* `repo_path` is also missing from jamun configs[4]
* some platforms configs are missing as well for fennec. Something like [5] should be available in [4] as it's being used in the fennec builder[6]

Even if we fixed the above, I still think it won't work as jamun configs indicate the staging bouncer[7] while the BB will provide the real credentials for the real production one. Unless the passwords match (which it possible), this will fail anyway for 403. I'm not sure if there's a clear separation from this perspective, BB-wise.

To be honest, I don't think we should invest time in this as we're likely to transition these builders off BB by the end of the year. Alternatively, steps above should make this builder work.

[1]: https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l2203
[2]: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py#l2342
[3]: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/project_branches.py#l197
[4]: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/project_branches.py#l114
[5]: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py#l1564
[6]: https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l2221
[7]: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/project_branches.py#l114

Comment 2

[Johan Lorenzo [:jlorenzo]]

[1] got 2 other tasks failing for the same apparent reason. I think we can tackle all 3 in this bug.

[1] https://tools.taskcluster.net/groups/T2TDo_JNTP2LMfneMcHONA

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

We now have dedicated bouncer instance and things work as expected in staging too.
Moreever, we're transitioning off Buildbot soon so I think we can close this.