Closed Bug 1346899 Opened 3 years ago Closed 3 years ago

[tcmigration] enable Fennec BuildBot builders to unblock the Phase2 remaining BBB jobs

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mtabara, Assigned: mtabara)

References

Details

Attachments

(4 files, 1 obsolete file)

Push to releases builder worked for Fennec 53.0b1 - http://archive.mozilla.org/pub/mobile/releases/53.0b1/ via https://tools.taskcluster.net/task-group-inspector/#/vo2JO4PYTGCJxFPXSFSv5g/cOlkME2XQfWz1T9T9qY4sw?_k=t94psn

But, the other builders:
* uptake monitoring
* mark release as shipped 
* bouncer aliases

.. have all failed because we didn't enabled the BB builders for them:

rail> https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/builder_master.cfg#155-160
00:20:48 <rail> maybe even need to revise https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/builder_master.cfg#153
00:20:50 <mtabara> is it just me or it's a simple oneliner with 'fennec' near that 'firefox' string?
00:20:55 <rail> and make it per product
00:21:07 <rail> not sure
00:21:19 <rail> may need to touch release.py as well

We need to fix this in order to unblock these builders.
@rail: so I'm not sure what to start with first here. Should we attempt a change of [1] + reconfig to see if it works first?

[1]: https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/builder_master.cfg#153
Flags: needinfo?(rail)
I don't think it is that simple.

1) that block enables https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l1778 which assumes a lot of things. For example it uses "linux64" explicitly in some places, what may not work.

2) the enabled builder names may collide with names in https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l53, because we still need old BB builders for Fennec 52.


You can probably do

a) change generateReleasePromotionBuilders to handle fennec
b) add another function (fork generateReleasePromotionBuilders) for fennec only

b) sounds clearer, even though there will be a lot of repetition. It'll be much easier to change it and kill it at some point.
Flags: needinfo?(rail)
Blocks: 1347637
Just wanted to know if I'm on the right track with this. Not sure what my next steps should be - how do I test this once I think I'm done?
Assignee: nobody → mtabara
Status: NEW → ASSIGNED
Attachment #8847708 - Flags: feedback?(rail)
Just wanted to know if I'm on the right track with this. Not sure what my next steps should be - how do I test this once I think I'm done?
Attachment #8847709 - Flags: feedback?(rail)
Priority: -- → P1
Comment on attachment 8847708 [details] [diff] [review]
WIP - tweak bbconfigs to take into account Fennec BB builders.

Review of attachment 8847708 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. For consistency, can you also add it to mozilla/universal_master_sqlite.cfg.
Attachment #8847708 - Flags: feedback?(rail) → feedback+
Comment on attachment 8847709 [details] [diff] [review]
WIP - tweak bbcustom to take into account Fennec BB builders.

Review of attachment 8847709 [details] [diff] [review]:
-----------------------------------------------------------------

It should just work. :) A nit below.

::: process/release.py
@@ +2164,5 @@
> +    bouncer_buildername = "release-{branch}-{product}_bncr_sub".format(
> +        branch=branch_name, product=product)
> +    # Explicitly define pf using the slave platform (linux64 in this case)
> +    bouncer_submitter_factory = makeMHFactory(
> +        config=branch_config, pf=branch_config["platforms"]['linux64'],

Instead of linux64, you probably want to use android-*, because we may disable linux64 at some point.
Attachment #8847709 - Flags: feedback?(rail) → feedback+
Comment on attachment 8848074 [details]
Bug 1346899 - tweak bbconfigs to take into account Fennec BB builders.

https://reviewboard.mozilla.org/r/121034/#review123046
Attachment #8848074 - Flags: review?(rail) → review+
Comment on attachment 8848075 [details]
Bug 1346899 - add short name for Fennec to fix normalized relpro Fennec builders.

https://reviewboard.mozilla.org/r/121052/#review123048
Attachment #8848075 - Flags: review?(rail) → review+
Comment on attachment 8848075 [details]
Bug 1346899 - add short name for Fennec to fix normalized relpro Fennec builders.

https://hg.mozilla.org/build/buildbotcustom/rev/14f31d0876a2
Attachment #8848075 - Flags: checked-in+
Comment on attachment 8848075 [details]
Bug 1346899 - add short name for Fennec to fix normalized relpro Fennec builders.

https://reviewboard.mozilla.org/r/121052/#review123602
https://hg.mozilla.org/build/buildbotcustom/rev/013df149b6ff
Bug 1346899 - add short name for Fennec to fix normalized relpro Fennec builders. r=rail
To make BBB Fennec builders work, we need to add some work in both buildbotcustom + bb-configs.

I've landed the buildbotcustom stuff already since it's harmless:
1) https://hg.mozilla.org/build/buildbotcustom/rev/14f31d0876a2
2) https://hg.mozilla.org/build/buildbotcustom/rev/013df149b6ff

With those patches into place, buildbot-configs is our last enemy standing.
Touched the bbconfigs and now they're green on Github mirror - 
https://github.com/mozilla-releng/build-buildbot-configs/pull/9/files

Once we land this and do a reconfig, the BBB Fennec jobs *should* just work!
The only thing left to do is to fix the releasetasks graph generation's scopes issues and we're all set.
Attachment #8848074 - Attachment is obsolete: true
Attachment #8848674 - Flags: review?(rail)
Comment on attachment 8848674 [details]
Bug 1346899 - tweak bbconfigs to take into account Fennec BB builders. r=rail

LGTM. We can try to land this today.
Attachment #8848674 - Flags: review?(rail) → review+
Comment on attachment 8848674 [details]
Bug 1346899 - tweak bbconfigs to take into account Fennec BB builders. r=rail

https://hg.mozilla.org/build/buildbot-configs/rev/5c0888fc8c30daaccbda68587fc3259dbab8bc14
Attachment #8848674 - Flags: checked-in+
Thanks :rail for landing the bb-configs changes. Sounds like it worked smoothly as I can see a beta Fennec graph from last week - https://tools.taskcluster.net/task-group-inspector/#/37sdAbs6TDW0vM6voulIMA?_k=6ijd2e.

Coolio, I guess we can close this now.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
See Also: → 1394747
You need to log in before you can comment on or make changes to this bug.