1394786 - Sharing URLs does not work on iOS 11

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Sharing to most other apps has regressed where the other app’s share extension either does not open at all, or opens with no data. Example: iMessage, Things, Notes, Twitter.

Also, our own share extensions do not work anymore when sharing to them from Firefox. Most likely for the same reason. (They do work when invoked from for example Safari - this is certainly a bug in our app, not in our extensions)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is an iOS 11 specific bug.

STR:

1) Navigate to a page
2) Share to for example iMessage, Notes, Twitter or really any app that works under iOS 10

Expected: share extension appears with both title and URL

Actual: share extension does not appear. Or it appear empty.

Comment 2

[:garvan]

Notes while I investigate:
Debugging the SendTo extension, I see this error
`Cannot load representation of type org.appextension.fill-browser-action`

Stefan can you add a comment on your workaround?

Comment 3

[:garvan]

I have this fixed (well, I think so), just adding more dev notes for myself.

Original bug for action extension UTI type setup: https://bugzilla.mozilla.org/show_bug.cgi?id=1162174

Just returning UTI type of 'public.url' here: https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Share/ShareExtensionHelper.swift#L112

Works for SendTo and for password fill extensions (I tested with last pass, and it filled no problem).

Comment 4

[:garvan]

Attachment: Pull request

I have tested this quite a bit at this point and it seems ok

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8905353 [details] [review]
Pull request

This breaks 1Password and Dashlane on iOS10. :(

Comment 6

[:garvan]

Thanks James, I should have checked those (TIL we supported Dashlane!). LastPass seemed to use the same code paths as 1PW. Installing those now and checking this out.

Comment 7

[:garvan]

planning to land that patch as a temporary fix, it will break 1Password integration (but everything else works ok).
I assume we keep this bug open while we work on a better long-term solution?

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1397887 is about bringing 1Password support back.

Comment 9

[:garvan]

landed on master and uplifted to v9.x

Comment 11

[Aaron Train [:aaronmt]]

Sounds like we will need a release note

Comment 12

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #11)
> Sounds like we will need a release note

for 1Password

Comment 13

[:garvan]

1Password bug for this:
https://github.com/agilebits/onepassword-app-extension/issues/385

Comment 14

[Richard Newman [:rnewman]]

master: 39e43a05c3fde65d6b895cebe917e3fb923ef100

Unfortunately, this doesn't work for my local Fennec build: it makes our extensions disappear altogether.

Comment 15

[Richard Newman [:rnewman]]

Oh, this is the opposite direction of the fix for me. Nm.

Comment 16

[:garvan]

This bug is filed to 1PW, their iOS sample code exhibits the same problem:
https://github.com/agilebits/onepassword-app-extension/issues/385