Closed Bug 1394883 Opened 3 years ago Closed 3 years ago

Use /builds/worker on decision task image, too

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla57

People

(Reporter: dustin, Assigned: dustin)

References

Details

Attachments

(5 files)

This will require some care to ensure that old and new action tasks as well as cron tasks all do the right thing.
Why?
So we're not trying to remember which jobs run in /builds and which in /home
Duplicate of this bug: 1395405
Comment on attachment 8902800 [details]
Bug 1394883: clean up some leftover uses of /home/worker;

https://reviewboard.mozilla.org/r/174472/#review179968
Attachment #8902800 - Flags: review?(wcosta) → review+
Comment on attachment 8902802 [details]
Bug 1394883: use /builds/worker in decision images;

https://reviewboard.mozilla.org/r/174476/#review179970
Attachment #8902802 - Flags: review?(wcosta) → review+
Comment on attachment 8902803 [details]
Bug 1394883: update docs about docker hashes;

https://reviewboard.mozilla.org/r/174478/#review179972
Attachment #8902803 - Flags: review?(wcosta) → review+
Thanks for working on this :)
Fixing this will hopefully fix backfilling that still references /builds/worker but uses the decision tasks image.

See:
https://hg.mozilla.org/integration/autoland/file/6b9d06ba6f769234530ae67d8353377d58a93fd0/taskcluster/taskgraph/actions/registry.py#l244

and bug 1395563
See Also: → 1395563
Comment on attachment 8902801 [details]
Bug 1394883: use /builds/worker in image building;

https://reviewboard.mozilla.org/r/174474/#review180034

Seems reasonable. I feel much better about refactors like this with the more robust cache and volume checking in run-task. Although, decision and image_builder are special, so the checks aren't as robust.
Attachment #8902801 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a579a5054ef
clean up some leftover uses of /home/worker; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/9426705a05af
use /builds/worker in image building; r=gps
https://hg.mozilla.org/integration/autoland/rev/081f830cf285
use /builds/worker in decision images; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/e3f42eca51c1
update docs about docker hashes; r=wcosta
See Also: → 1338651
Weird. This docker-image task doesn't look like it has a task.payload.command at all.
https://queue.taskcluster.net/v1/task/Uz6HOfvbTFuawVxIGbqQtQ
Yeah, they never did -- CoT accepted either no command or a command with /home/worker, but in bug 1395680 we disallowed the no-command option.
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1086c3de5527
clean up some leftover uses of /home/worker; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/2602ae38ffb3
use /builds/worker in image building; r=gps
https://hg.mozilla.org/integration/autoland/rev/2923a42eb5df
use /builds/worker in decision images; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/a5a0fb1070cb
update docs about docker hashes; r=wcosta
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.