1394883 - Use /builds/worker on decision task image, too

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This will require some care to ensure that old and new action tasks as well as cron tasks all do the right thing.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfa45f01bea3ea4a3f869a8dc58f3d36e92ce3a0

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36505c9a206f9cd469b91201bddb51fc54c21163

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=52786c1b82102cb853d77e1203a1186380d8375f

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af0394faaf1fe49f31e15fdccf14dba9889276ae

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a792558bea5976e6b44b9d801fc34f3e68b02026

Comment 6

[Gregory Szorc [:gps]]

Why?

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

So we're not trying to remember which jobs run in /builds and which in /home

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68db92c17484eeaa3aef3eafea11ab735449ac0a

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Decision: https://tools.taskcluster.net/task-inspector/#bDTHx5m0ReKDdclqOVRA4g
Action: https://tools.taskcluster.net/groups/bDTHx5m0ReKDdclqOVRA4g/tasks/BUVjK4pLQ3aDdLlU98ADCA
Old Actions: https://queue.taskcluster.net/v1/task/Nj8dUecfRoevuwfx8Ttu5Q/runs/0/artifacts/public/action.yml
Docker Image: https://tools.taskcluster.net/task-inspector/#RtVgukWNT72FXhfQt4r0eQ

I'm confident about cron tasks (they process .taskcluster.yml with json-e, so if the decision task worked, they will too)

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1394883: clean up some leftover uses of /home/worker;

Review commit: https://reviewboard.mozilla.org/r/174472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174472/

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1394883: use /builds/worker in image building;

This includes adding TASKCLUSTER_VOLUMES to docker image builds directly.  The
env variable is not added as part of the task transform because `run-task` is
not in payload.command.  In fact, build-image.sh calls run-task after doing
some other housekeeping.

Ideally image builds would be turned into jobs and all of this would occur
automatically, but that turns out to be quite a bit too complex for this
incidental fix -- perhaps best solved in another bug.

Review commit: https://reviewboard.mozilla.org/r/174474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174474/

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1394883: use /builds/worker in decision images;

Review commit: https://reviewboard.mozilla.org/r/174476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174476/

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1394883: update docs about docker hashes;

Review commit: https://reviewboard.mozilla.org/r/174478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174478/

Comment 15

[Wander Lairson Costa]

Comment on attachment 8902800 [details]
Bug 1394883: clean up some leftover uses of /home/worker;

https://reviewboard.mozilla.org/r/174472/#review179968

Comment 16

[Wander Lairson Costa]

Comment on attachment 8902802 [details]
Bug 1394883: use /builds/worker in decision images;

https://reviewboard.mozilla.org/r/174476/#review179970

Comment 17

[Wander Lairson Costa]

Comment on attachment 8902803 [details]
Bug 1394883: update docs about docker hashes;

https://reviewboard.mozilla.org/r/174478/#review179972

Comment 18

[Wander Lairson Costa]

Thanks for working on this :)

Comment 19

[Greg Arndt [:garndt]]

Fixing this will hopefully fix backfilling that still references /builds/worker but uses the decision tasks image.

See:
https://hg.mozilla.org/integration/autoland/file/6b9d06ba6f769234530ae67d8353377d58a93fd0/taskcluster/taskgraph/actions/registry.py#l244

and bug 1395563

Comment 20

[Gregory Szorc [:gps]]

Comment on attachment 8902801 [details]
Bug 1394883: use /builds/worker in image building;

https://reviewboard.mozilla.org/r/174474/#review180034

Seems reasonable. I feel much better about refactors like this with the more robust cache and volume checking in run-task. Although, decision and image_builder are special, so the checks aren't as robust.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a579a5054ef
clean up some leftover uses of /home/worker; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/9426705a05af
use /builds/worker in image building; r=gps
https://hg.mozilla.org/integration/autoland/rev/081f830cf285
use /builds/worker in decision images; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/e3f42eca51c1
update docs about docker hashes; r=wcosta

Comment 22

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/mozilla-releng/scriptworker/pull/152

Comment 23

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1394883: update hashes;

Review commit: https://reviewboard.mozilla.org/r/175038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175038/

Comment 24

[Aki Sasaki (not active)]

Comment on attachment 8903243 [details]
Bug 1394883: update hashes;

https://reviewboard.mozilla.org/r/175038/#review180084

Comment 25

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/85e0bc442b61 for Windows signing chain-of-trust failures like https://public-artifacts.taskcluster.net/AiB8WHKiT5uUOoTpxXHWLg/0/public/logs/chain_of_trust.log

Comment 26

[Aki Sasaki (not active)]

Weird. This docker-image task doesn't look like it has a task.payload.command at all.
https://queue.taskcluster.net/v1/task/Uz6HOfvbTFuawVxIGbqQtQ

Comment 27

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, they never did -- CoT accepted either no command or a command with /home/worker, but in bug 1395680 we disallowed the no-command option.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1086c3de5527
clean up some leftover uses of /home/worker; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/2602ae38ffb3
use /builds/worker in image building; r=gps
https://hg.mozilla.org/integration/autoland/rev/2923a42eb5df
use /builds/worker in decision images; r=wcosta
https://hg.mozilla.org/integration/autoland/rev/a5a0fb1070cb
update docs about docker hashes; r=wcosta

Comment 29

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1086c3de5527
https://hg.mozilla.org/mozilla-central/rev/2602ae38ffb3
https://hg.mozilla.org/mozilla-central/rev/2923a42eb5df
https://hg.mozilla.org/mozilla-central/rev/a5a0fb1070cb