1395063 - Use MOZ_CRASH directly in mozjemalloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1395063 - Use MOZ_CRASH directly in mozjemalloc.

Back when mozjemalloc was considered third-party, and before bug
1365194, mozjemalloc was calling abort() and that was redirectory to
MOZ_CRASH through a moz_abort() function. Bug 1365194 changed that so
that moz_abort is called directly instead of abort, but the indirection
is actually not necessary anymore.

So we just kill moz_abort, which is unused anywhere else, and use
MOZ_CRASH directly.

Note this will (obviously) change crash signatures involving moz_abort.

Review commit: https://reviewboard.mozilla.org/r/174144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174144/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8902546 [details]
Bug 1395063 - Use MOZ_CRASH directly in mozjemalloc.

https://reviewboard.mozilla.org/r/174144/#review179442

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a1f4fe397d9
Use MOZ_CRASH directly in mozjemalloc. r=njn

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1a1f4fe397d9