Closed Bug 1395141 Opened 3 years ago Closed 3 years ago

RequestInit.signal should be marked as optional AbortSignal

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

The spec used to say that it had to be: dictionary RequestInit { ... AbortSignal signal; ... }
Attached patch abort_3.patchSplinter Review
Attachment #8902679 - Flags: review?(bkelly)
Depends on: 1378342
Comment on attachment 8902679 [details] [diff] [review]
abort_3.patch

Review of attachment 8902679 [details] [diff] [review]:
-----------------------------------------------------------------

The spec editor made this change in the proposed spec as well after we discussed the test failure with him.  Thanks!
Attachment #8902679 - Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8369cf48aeb
RequestInit dictionary must have AbortSignal as optional, r=bkelly
https://hg.mozilla.org/mozilla-central/rev/a8369cf48aeb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Wait, is this about optionality or nullability?  The member was optional before this change, and still is; what changed is that it's now nullable, right?
Correct.  The intent is nullability.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.