RequestInit.signal should be marked as optional AbortSignal

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
The spec used to say that it had to be: dictionary RequestInit { ... AbortSignal signal; ... }
(Assignee)

Comment 1

3 months ago
Created attachment 8902679 [details] [diff] [review]
abort_3.patch
Attachment #8902679 - Flags: review?(bkelly)
(Assignee)

Updated

3 months ago
Depends on: 1378342

Updated

3 months ago
Blocks: 1394085

Comment 2

3 months ago
Comment on attachment 8902679 [details] [diff] [review]
abort_3.patch

Review of attachment 8902679 [details] [diff] [review]:
-----------------------------------------------------------------

The spec editor made this change in the proposed spec as well after we discussed the test failure with him.  Thanks!
Attachment #8902679 - Flags: review?(bkelly) → review+

Comment 3

3 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8369cf48aeb
RequestInit dictionary must have AbortSignal as optional, r=bkelly

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8369cf48aeb
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Wait, is this about optionality or nullability?  The member was optional before this change, and still is; what changed is that it's now nullable, right?

Comment 6

3 months ago
Correct.  The intent is nullability.
You need to log in before you can comment on or make changes to this bug.