1395141 - RequestInit.signal should be marked as optional AbortSignal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

The spec used to say that it had to be: dictionary RequestInit { ... AbortSignal signal; ... }

Comment 1

[Andrea Marchesini [:baku]]

Attachment: abort_3.patch

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8902679 [details] [diff] [review]
abort_3.patch

Review of attachment 8902679 [details] [diff] [review]:
-----------------------------------------------------------------

The spec editor made this change in the proposed spec as well after we discussed the test failure with him.  Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8369cf48aeb
RequestInit dictionary must have AbortSignal as optional, r=bkelly

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8369cf48aeb

Comment 5

[Boris Zbarsky [:bzbarsky]]

Wait, is this about optionality or nullability?  The member was optional before this change, and still is; what changed is that it's now nullable, right?

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Correct.  The intent is nullability.