Closed
Bug 1394085
Opened 7 years ago
Closed 7 years ago
Enable Abort API by default
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
857 bytes,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Bug 1378342 implements abort API enabling it only in nightly. When stable, this API should be enabled by default.
Updated•7 years ago
|
Blocks: ServiceWorkers-compat
Assignee | ||
Comment 1•7 years ago
|
||
For sure, abort API can be enabled right now. Fetch + Abort can maybe wait. I'm going to write an email to dev-platform about it.
Assignee: nobody → amarchesini
Attachment #8902109 -
Flags: review?(bkelly)
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 2•7 years ago
|
||
What can devs do with this API right now without the fetch bits?
Flags: needinfo?(amarchesini)
Comment 3•7 years ago
|
||
Comment on attachment 8902109 [details] [diff] [review] enable1.patch I'd like to wait to enable until bug 1394102 is fixed. Also, I think we should fix more of these test failures: https://hg.mozilla.org/integration/mozilla-inbound/file/92692c9a4f1e/testing/web-platform/meta/fetch/api/abort/general.html.ini https://hg.mozilla.org/integration/mozilla-inbound/file/92692c9a4f1e/testing/web-platform/meta/fetch/api/abort/general-serviceworker.https.html.ini
Attachment #8902109 -
Flags: review?(bkelly)
Comment 4•7 years ago
|
||
Ok, the test failures mentioned in comment 3 are all valid for now. They are basically 3 test cases: 1. "Signal removed by setting to null" fails because the webidl forbids it. Jake is going to fix the test. 2. "Stream will not error if body is empty. It's closed with an empty queue before it errors" fails because the test assumes the network stack completes the empty response body when the headers are available. Our network stack uses a separate task to fire OnStopRequest(). AFAICT this is fine by the spec. So this test seems suspect as well. Jake is going to look at it. 3. "Readable stream synchronously cancels with AbortError if aborted before reading" fails because we don't implement Request.body ReadableStream yet. So I think bug 1394102 is the main blocker to shipping at the moment.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Attachment #8902109 -
Flags: review?(bkelly)
Comment 5•7 years ago
|
||
Comment on attachment 8902109 [details] [diff] [review] enable1.patch Review of attachment 8902109 [details] [diff] [review]: ----------------------------------------------------------------- Please send a follow-up email to dev-platform indicating that we intend to ship this in FF57. Thanks!
Attachment #8902109 -
Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6efb07607b1 Enable Abort API by default, r=bkelly
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f6efb07607b1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 8•7 years ago
|
||
Documentation sorted for this; see https://bugzilla.mozilla.org/show_bug.cgi?id=1378342#c44
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•