1395147 - [Shield][Opt-Out]Second page extensions cannot be used in recipes

Status: VERIFIED FIXED

(Shield :: General, defect)

Description

[Deac Alin]

Preconditions
You need access to Admin interface (for this Test Suite, https://normandy-admin.stage.mozaws.net/control
1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
5. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1

[Steps:]
1. Open FF with a new profile, and set the preconditions.
2. Open admin at https://normandy-admin.stage.mozaws.net/control/extension/
3. Create new Extensions until the first page is filled (10)
4. Create one more Extension(11th) which will be located on the second page
5. Create a new recipe(Action - Opt-out Study) and from the ADD-ON drop down, select the Extension created at step 4

[Actual Result:]
5. The Extension cannot be selected from the ADD-ON drop down, as it is located on the second page(which is not readable at this moment - only the first 10 created extensions can be used)

[Expected Result:]
5. The Extension can be selected and used.
   All the Extensions can be selected and used

Note: Blocker severity as the extensions cannot be deleted and replaced, for testing.

Comment 1

[Osmose [:osmose, :mkelly]]

https://github.com/mozilla/normandy/issues/1005 should fix this indirectly, by fixing the bug that prevents us from using the new control interface for testing. Once it lands, we can switch to using the new interface (currently available at https://normandy-admin.stage.mozaws.net/control-new/) for testing. 

Let me know if switching interfaces in the middle of testing is too disruptive; we can look at fixing the old interface as well if that's a problem.

Comment 2

[Adrian Florinescu [:aflorinescu]]

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #1)
> https://github.com/mozilla/normandy/issues/1005 should fix this indirectly,
> by fixing the bug that prevents us from using the new control interface for
> testing. Once it lands, we can switch to using the new interface (currently
> available at https://normandy-admin.stage.mozaws.net/control-new/) for
> testing. 
> 
> Let me know if switching interfaces in the middle of testing is too
> disruptive; we can look at fixing the old interface as well if that's a
> problem.

There's no problem from the QA side on using the new admin interface. We were checking anyways if we can use the new interface for the issues we have/had in the old admin interface. The only concern about switching to the new interface is that the workflow was not vetted against it, so in case it introduces something major that will affect FF or shield stability we would not know it.

Comment 3

[Osmose [:osmose, :mkelly]]

The PR in comment 1 landed, as well as the followup https://github.com/mozilla/normandy/pull/1048. They've both been deploying to staging.

The new control interface is available at https://normandy-admin.stage.mozaws.net/control-new/ and should be usable for all of your testing needs. The UI isn't too far from the old UI; the main difference we've heard that is tripping people up is that, after editing or approving a recipe, you need to go back to the View Recipe page to publish / submit the recipe for approval.

Alin: Can you verify that the new control interface is suitable for your testing needs?

Comment 4

[Deac Alin]

Attachment: Screen Shot 2017-09-08 at 15.51.16.png

Hi Michael,

Just checked the new control interface and when creating a new opt-out-study Recipe, the latest created Extensions cannot be selected from the Add-on Extension menu( only the first 4 in the list - check the attached screenshot)

Comment 5

[Deac Alin]

Based on the above comment 4 reopening this issue. Please let me know if you want another ticket for the above specific problem. Thank you

Comment 6

[Michael Cooper [:mythmon]]

Attachment: 30070355-63e0b628-9220-11e7-92d1-70d6446fc586.png

This is an unfortunate UI bug. To fix the problem of only being able to use the first page of extensions, we implemented a search system. The box in the screenshot is actually a text input, and if you type the name of the extension you want in it, the list will filter down to show only matching extensions. This makes all extensions available.

The bug is that the UI elements that make the input box look like a search box aren't rendering. The interface is expected to look like the screenshot I've attached. I've filed an issue about the UI bug: https://github.com/mozilla/normandy/issues/1051

Comment 7

[Osmose [:osmose, :mkelly]]

Marking this as fixed, as the control functions now (you can select studies, or at least I was able to do so using the instructions from Comment 6 on staging just now).

There's still some remaining polish to make it more usable, but this shouldn't be blocking testing anymore.

Comment 8

[Adrian Florinescu [:aflorinescu]]

Marking this as verified fixed on 56.0b12 20170914024831 Windows 10, Mac OSX 10.12
:Osmose, let me know if we track the remaining admin polish for this section in bugzilla or in git.

Comment 9

[Osmose [:osmose, :mkelly]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #8)
> :Osmose, let me know if we track the remaining admin polish for this section
> in bugzilla or in git.

On Github. I've got a todo item to make sure any remaining issues are filed there, lemme know if you want me to @ you on them (I don't actually know what your Github handle is :P).