1395244 - index out of bounds [@ mp4parse_get_indice_table]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Tyson Smith [:tsmith] (PTO)]

Attachment: test_case.mp4

thread '<unnamed>' panicked at 'index out of bounds: the len is 0 but the index is 0', /checkout/src/libcollections/vec.rs:1552
stack backtrace:
   0:     0x7f19b921ac03 - std::sys::imp::backtrace::tracing::imp::unwind_backtrace::hcab99e0793da62c7
                               at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1:     0x7f19b9217bc9 - std::panicking::default_hook::{{closure}}::h9ba2c6973907a2be
                               at /checkout/src/libstd/sys_common/backtrace.rs:71
                               at /checkout/src/libstd/sys_common/backtrace.rs:60
                               at /checkout/src/libstd/panicking.rs:355
   2:     0x7f19b9216ff0 - std::panicking::default_hook::he4d55e2dd21c3cca
                               at /checkout/src/libstd/panicking.rs:371
   3:     0x7f19b9216b15 - std::panicking::rust_panic_with_hook::ha138c05cd33ad44d
                               at /checkout/src/libstd/panicking.rs:549
   4:     0x7f19b9216a2f - std::panicking::begin_panic::hcdbfa35c94142fa2
                               at /checkout/src/libstd/panicking.rs:511
   5:     0x7f19b9216999 - std::panicking::begin_panic_fmt::hc09fe500d9b7be81
                               at /checkout/src/libstd/panicking.rs:495
   6:     0x7f19b92247c6 - core::panicking::panic_fmt::h883a028e9f4b4457
                               at /checkout/src/libstd/panicking.rs:471
   7:     0x7f19b922432c - core::panicking::panic_bounds_check::hc3c2775988732c0b
                               at /checkout/src/libcore/panicking.rs:56
   8:     0x7f19b914582f - mp4parse_get_indice_table
                               at /checkout/src/libcollections/vec.rs:1552
                               at /home/worker/workspace/build/src/media/libstagefright/binding/mp4parse_capi/src/lib.rs:999
                               at /home/worker/workspace/build/src/media/libstagefright/binding/mp4parse_capi/src/lib.rs:701
   9:     0x7f19ac54ac0f - _ZN11mp4_demuxer15MP4MetadataRust15ReadTrackIndiceEP18mp4parse_byte_datai
                               at /home/worker/workspace/build/src/media/libstagefright/binding/MP4Metadata.cpp:1008
  10:     0x7f19ac54871f - _ZN11mp4_demuxer11MP4Metadata14GetTrackIndiceEi
                               at /home/worker/workspace/build/src/media/libstagefright/binding/MP4Metadata.cpp:433
  11:     0x7f19b1e78a2e - _ZN7mozilla10MP4Demuxer4InitEv
                               at /home/worker/workspace/build/src/dom/media/fmp4/MP4Demuxer.cpp:247
  12:     0x7f19b1828a1f - _ZN7mozilla6detail21ProxyFunctionRunnableIZNS_17MediaFormatReader12DemuxerProxy4InitEvE4$_10NS_10MozPromiseINS_11MediaResultES6_Lb1EEEE3RunEv
                               at /home/worker/workspace/build/src/dom/media/MediaFormatReader.cpp:1027
                               at /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/MozPromise.h:1511
  13:     0x7f19ac7a8cec - _ZN7mozilla9TaskQueue6Runner3RunEv
                               at /home/worker/workspace/build/src/xpcom/threads/TaskQueue.cpp:246
  14:     0x7f19ac7ca461 - _ZN12nsThreadPool3RunEv
                               at /home/worker/workspace/build/src/xpcom/threads/nsThreadPool.cpp:226
  15:     0x7f19ac7ca95c - _ZThn16_N12nsThreadPool3RunEv
                               at /home/worker/workspace/build/src/xpcom/threads/nsThreadPool.cpp:154
  16:     0x7f19ac7c131d - _ZN8nsThread16ProcessNextEventEbPb
                               at /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1039
  17:     0x7f19ac7c6958 - _Z19NS_ProcessNextEventP9nsIThreadb
                               at /home/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:521
  18:     0x7f19ad55b41d - _ZN7mozilla3ipc28MessagePumpForNonMainThreads3RunEPN4base11MessagePump8DelegateE
                               at /home/worker/workspace/build/src/ipc/glue/MessagePump.cpp:338
  19:     0x7f19ad4bab8b - _ZN11MessageLoop3RunEv
                               at /home/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:326
                               at /home/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:319
                               at /home/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:299
  20:     0x7f19ac7bbccf - _ZN8nsThread10ThreadFuncEPv
                               at /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp:427
  21:     0x7f19c77854d3 - _pt_root
                               at /home/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:216
  22:     0x7f19cb1636b9 - start_thread
  23:     0x7f19ca1ec3dc - clone
  24:                0x0 - <unknown>

Comment 1

[Alfredo Yang (:alfredo)]

Invalid table content.

SampleToChunkBox { samples: [SampleToChunk { first_chunk: 100663297, samples_per_chunk: 2, sample_description_index: 1 }, SampleToChunk { first_chunk: 2, samples_per_chunk: 1, sample_description_index: 1 }] }

Comment 2

[Alfredo Yang (:alfredo)]

https://github.com/mozilla/mp4parse-rust/pull/113

Comment 3

[Alfredo Yang (:alfredo)]

Attachment: Bug 1395244 - check sample_table before using.

Review commit: https://reviewboard.mozilla.org/r/176294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176294/

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: Bug 1395244 - add gtest for index out of bounds in rust mp4 parser.

Review commit: https://reviewboard.mozilla.org/r/176296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176296/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8904443 [details]
Bug 1395244 - check sample_table before using.

https://reviewboard.mozilla.org/r/176294/#review181202

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8904444 [details]
Bug 1395244 - add gtest for index out of bounds in rust mp4 parser.

https://reviewboard.mozilla.org/r/176296/#review181204

Comment 7

[Alfredo Yang (:alfredo)]

Comment on attachment 8904444 [details]
Bug 1395244 - add gtest for index out of bounds in rust mp4 parser.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176296/diff/1-2/

Comment 8

[Alfredo Yang (:alfredo)]

MP4 parser already updated in bug 1401071.

Comment 9

[Alfredo Yang (:alfredo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fe23aa81fbdd7d46102f4744188e421eb7344bd

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6010c5796517
add gtest for index out of bounds in rust mp4 parser. r=kinetik

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6010c5796517