Open Bug 1395488 Opened 2 years ago Updated 2 years ago

stylo: shrink nsStyleDisplay, nsStylePosition and ServoComputedData

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix

People

(Reporter: heycam, Assigned: emilio)

References

(Blocks 1 open bug)

Details

nsStyleDisplay and nsStylePosition are massive, and we often have a lot of them.  I think they still have some room for packing by shuffling some fields around.  Also, ServoComputedData could shrink by a word by packing the FontComputationData up around with the CascadeFlags and WritingMode.
I have something for Gecko, but doing it on the properties/gecko.mako.rs makes me sad. I'll refactor some stuff as I work on this.
Depends on: 1395586
Priority: -- → P3
Emilio, do we have credible optimizations to do here in the 57 timeframe?
Flags: needinfo?(emilio)
I can land bug 1395586, and the packing patch which save 4 words per nsStyleDisplay, but today I got distracted with other stuff.

Will want to land at least some shuffling of the field which gives us two words for free.
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Blocks: 1367854
status-firefox57=wontfix unless someone thinks this bug should block 57
You need to log in before you can comment on or make changes to this bug.