1695374 - Split nsStylePosition

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Boris Chiou [:boris]]

When I change the type of ExtremumLength to somthing like:

pub enum GenericExtremumLength<LengthPercent> {
    #[parse(aliases = "-moz-max-content")]
    MaxContent,
    #[parse(aliases = "-moz-min-content")]
    MinContent,
    MozFitContent,
    MozAvailable,
    FitContentFunc(LengthPercent),
}

This makes StyleSize and StyleMaxSize become 24 bytes (note: the original size is 16 bytes). The total size of nsStylePosition becomes 520 bytes, which is larger than 512 bytes. Perhaps need to figure out a way the make nsStylePosition smaller. Just reordering the struct members to reduce the memory padding doesn't help a lot for now.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Probably box some uncommon properties first?

Comment 2

[Boris Chiou [:boris]]

Based on the update of ExtremumLength (comment 0), the sizes of the data members in nsStylePosition:

data member	size (bytes)
mozilla::StyleAlignTracks mAlignTracks;	16
mozilla::StyleJustifyTracks mJustifyTracks;	16
Position mObjectPosition;	16
StyleRect<LengthPercentageOrAuto> mOffset;	32
StyleSize mWidth;	24
StyleSize mMinWidth;	24
StyleMaxSize mMaxWidth;	24
StyleSize mHeight;	24
StyleSize mMinHeight;	24
StyleMaxSize mMaxHeight;	24
mozilla::StyleFlexBasis mFlexBasis;	32
StyleImplicitGridTracks mGridAutoColumns;	16
StyleImplicitGridTracks mGridAutoRows;	16
mozilla::StyleAspectRatio mAspectRatio;	16
mozilla::StyleGridAutoFlow mGridAutoFlow;	1
uint8_t mMasonryAutoFlow;	1
mozilla::StyleAlignContent mAlignContent;	1
mozilla::StyleAlignItems mAlignItems;	1
mozilla::StyleAlignSelf mAlignSelf;	1
mozilla::StyleJustifyContent mJustifyContent;	1
mozilla::StyleComputedJustifyItems mJustifyItems;	2
mozilla::StyleJustifySelf mJustifySelf;	1
mozilla::StyleFlexDirection mFlexDirection;	1
mozilla::StyleFlexWrap mFlexWrap;	1
mozilla::StyleObjectFit mObjectFit;	1
mozilla::StyleBoxSizing mBoxSizing;	1
int32_t mOrder;	4
float mFlexGrow;	4
float mFlexShrink;	4
mozilla::StyleZIndex mZIndex;	8
mozilla::StyleGridTemplateComponent mGridTemplateColumns;	16
mozilla::StyleGridTemplateComponent mGridTemplateRows;	16
mozilla::StyleGridTemplateAreas mGridTemplateAreas;	16
mozilla::StyleGridLine mGridColumnStart;	16
mozilla::StyleGridLine mGridColumnEnd;	16
mozilla::StyleGridLine mGridRowStart;	16
mozilla::StyleGridLine mGridRowEnd;	16
mozilla::NonNegativeLengthPercentageOrNormal mColumnGap;	16
mozilla::NonNegativeLengthPercentageOrNormal mRowGap;	16

Comment 3

[Emilio Cobos Álvarez (:emilio)]

If you put fit-content in GenericSize / GenericMaxSize it shouldn't grow. Would that work? The reason they're in a separate enum is kind of ad-hoc anyways, ExtremumLength doesn't signify anything. So we could also just derive(Parse) and put the keywords directly in Size / MaxSize.

Comment 4

[Boris Chiou [:boris]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

If you put fit-content in GenericSize / GenericMaxSize it shouldn't grow. Would that work? The reason they're in a separate enum is kind of ad-hoc anyways, ExtremumLength doesn't signify anything. So we could also just derive(Parse) and put the keywords directly in Size / MaxSize.

Yes. This makes sense. Thanks for file the bug. :)

Comment 5

[Boris Chiou [:boris]]

(In reply to Xidorn Quan [:xidorn] UTC+11 from comment #1)

Probably box some uncommon properties first?

Yes. This should be a quick way. Most of the large data members are related to grid and size, so perhaps need to box others. Otherwise, we need to make sure the the large data members not grow too much.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Another option is to consider make StyleSize more compact. I don't think it's common case (either a pixel number or a percentage or auto) need 3 words. Maybe we can make them a compact pointer, for example, having the last two bits being the enum tag, and box all other cases. I think StyleSize should be common enough to be worth this special handling.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

We use that trick for LengthPercentage already, so StyleSize now (and after bug 1695390) would be just one word plus the 8-bit tag plus padding. I don't think we can fit all the other keywords in the remaining LengthPercentage bits so it seems it's as good as we can make it for now...

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Okay I think two words size is reasonable. It's probably hard to go down further.