Closed Bug 1395566 Opened 2 years ago Closed 2 years ago

Enable webrtc.org desktop capture tests.

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The webrtc.org desktop capture tests are not currently enabled. It looks like the platform independent test crashed on me, and I didn't try the platform specific tests.
Status: NEW → ASSIGNED
Comment on attachment 8904629 [details] [diff] [review]
Add more webrtc.org desktop capture unit tests

Review of attachment 8904629 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_unittest.cc
@@ +49,5 @@
>    }
>  
>    bool CreateDirectxCapturer() {
> +    // Mozilla builds do not include the DirectX Capturer
> +    /*

Please use an ifdef  -- WEBRTC_MOZILLA_BUILD probably
Attachment #8904629 - Flags: review?(rjesup) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bffbaa5f5924
Enable more webrtc.org desktop capture tests; r=jesup
https://hg.mozilla.org/mozilla-central/rev/bffbaa5f5924
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.