1395566 - Enable webrtc.org desktop capture tests.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Dan Minor [:dminor]]

The webrtc.org desktop capture tests are not currently enabled. It looks like the platform independent test crashed on me, and I didn't try the platform specific tests.

Comment 1

[Dan Minor [:dminor]]

Attachment: Add more webrtc.org desktop capture unit tests

Try jobs here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=783efc611cfb1112025d51d6fb07d218e5eb9389

with Windows build fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82af05c50dabd2a35574db8689899f4d5ab77a58

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8904629 [details] [diff] [review]
Add more webrtc.org desktop capture unit tests

Review of attachment 8904629 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_unittest.cc
@@ +49,5 @@
>    }
>  
>    bool CreateDirectxCapturer() {
> +    // Mozilla builds do not include the DirectX Capturer
> +    /*

Please use an ifdef  -- WEBRTC_MOZILLA_BUILD probably

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bffbaa5f5924
Enable more webrtc.org desktop capture tests; r=jesup

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bffbaa5f5924