Closed
Bug 139573
Opened 22 years ago
Closed 21 years ago
Classic theme: The UP/DOWN buttons are too small also without arrow
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: amyy, Assigned: tuukka.tolvanen)
References
Details
(Keywords: classic, intl, regression, Whiteboard: [adt3])
Attachments
(2 files, 3 obsolete files)
43.97 KB,
image/jpeg
|
Details | |
1.95 KB,
patch
|
Details | Diff | Splinter Review |
Build: 04-23 branch build on WinXP Set browser theme as Classic, go to View Character Coding | Customize... to bring up the Customize Character Coding dialog. You will see the up/down buttons are too small, also there are no arrows. - see a followed screen shot.
Reporter | ||
Comment 1•22 years ago
|
||
Modern theme doesn't has this problem.
Reporter | ||
Comment 2•22 years ago
|
||
Mac and linux has same problem.
OS: Windows XP → All
Hardware: PC → All
Comment 3•22 years ago
|
||
*** Bug 157024 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 5•22 years ago
|
||
For whatever reason, themes/classic/communicator/communicator.css defines rules for .up, .up[disabled="true"], .down and .down[disabled="true"] twice, starting at line 62 first and line 80 second. The second bunch is apparently bogus, since it references the files scroll-up.gif, scroll-up-disabled.gif, scroll-down.gif, scroll-down-disabled.gif, which don't exist; and doesn't add anything else. Patch removes those lines, and lo, the arrows appear. :P http://lxr.mozilla.org/seamonkey/source/themes/classic/communicator/communicator.css#62 The nav>languages pref panel also regains the arrows on the "Move Up" and "Move Down" buttons. There are two inconsistencies: The mail>tools>filters dialog doesn't define the "up" and "down" class on similarly titled buttons, so no arrows there. Second, perhaps the mail>view>coding>customize dialog should have proper labels on the same buttons, in addition to the arrows. ...guess these are for another bug :)
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•22 years ago
|
||
feel free to r/sr/a/c
Assignee | ||
Updated•22 years ago
|
Comment 8•22 years ago
|
||
Comment on attachment 91066 [details] [diff] [review] diff -U 20 r=caillon
Attachment #91066 -
Attachment is patch: true
Attachment #91066 -
Flags: review+
Comment 9•22 years ago
|
||
We don't really want to REMOVE support for these arrows, we need to fix the broken urls. These arrows are now at chrome://global/skin/arrow/arrow-up.gif etc..
Assignee | ||
Updated•22 years ago
|
Attachment #91067 -
Attachment is obsolete: true
Assignee | ||
Comment 10•22 years ago
|
||
yes. the patch does not touch the valid urls such as ("chrome://global/skin/arrow/arrow-up.gif", ...) that are already there, it only removes the broken ones ("chrome://global/skin/scroll-up.gif, ...) overriding them.
Comment 11•21 years ago
|
||
i18n triage team: nsbeta1+/adt3
Assignee | ||
Comment 12•21 years ago
|
||
The arrows are in place now; the dup lines specifying the bogus images were removed by 1.10 timeless%mozdev.org Nov 20 2002 Bug 171485 Remove duplicates in classic communicator.css patch by walk84@yahoo.com r=shuehan sr=bz The "Move Up"/"Move Down" labels are still missing, though
Depends on: 171485
Assignee | ||
Comment 13•21 years ago
|
||
The buttons look as afaui they should in my tree; I haven't been around there for ages, but I presume it's because of these changes. Someone might want to verify that. This does make the labels longer, but I'd favor consistency with other such lists (mail>tools>filters, edit>prefs>nav>history).
Attachment #91066 -
Attachment is obsolete: true
Assignee | ||
Comment 14•21 years ago
|
||
s/history/languages/
Assignee | ||
Updated•21 years ago
|
Attachment #117136 -
Flags: review?(sgehani)
Comment 15•21 years ago
|
||
Comment on attachment 117136 [details] [diff] [review] patch to use labels and accesskeys, and add "Move " to the labels r=sgehani
Attachment #117136 -
Flags: review?(sgehani) → review+
Assignee | ||
Updated•21 years ago
|
Attachment #117136 -
Flags: superreview?(jaggernaut)
Comment 16•21 years ago
|
||
Comment on attachment 117136 [details] [diff] [review] patch to use labels and accesskeys, and add "Move " to the labels Could you make the accesskeys be uppercase to match the case of the text? They'll work as is, but first we do a case sensitive scan before doing a case insensitive scan. sr=jag, no new patch required
Attachment #117136 -
Flags: superreview?(jaggernaut)
Attachment #117136 -
Flags: superreview+
Attachment #117136 -
Flags: approval1.4b?
Comment 17•21 years ago
|
||
Comment on attachment 117136 [details] [diff] [review] patch to use labels and accesskeys, and add "Move " to the labels a=asa (on behalf of drivers) for checkin to 1.4b
Attachment #117136 -
Flags: approval1.4b? → approval1.4b+
Assignee | ||
Comment 18•21 years ago
|
||
with uppercase accesskeys per comment 16. jag, sgehani, will one of you check this in for me?
Attachment #117136 -
Attachment is obsolete: true
Assignee | ||
Comment 19•21 years ago
|
||
checked in by jag, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
QA Contact: pmac → gbush
Comment 20•21 years ago
|
||
verified mac and linux - trunk builds before branch
Status: RESOLVED → VERIFIED
Comment 21•21 years ago
|
||
*** Bug 138641 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•