Closed Bug 139573 Opened 22 years ago Closed 21 years ago

Classic theme: The UP/DOWN buttons are too small also without arrow

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: amyy, Assigned: tuukka.tolvanen)

References

Details

(Keywords: classic, intl, regression, Whiteboard: [adt3])

Attachments

(2 files, 3 obsolete files)

Build: 04-23 branch build on WinXP

Set browser theme as Classic, go to View Character Coding | Customize... to
bring up the Customize Character Coding dialog.  You will see the up/down
buttons are too small, also there are no arrows. - see a followed screen shot.
Modern theme doesn't has this problem.
Mac and linux has same problem.
OS: Windows XP → All
Hardware: PC → All
*** Bug 157024 has been marked as a duplicate of this bug. ***
copy keywords from duplicated bug, add intl
Keywords: intl, nsbeta1, regression
Attached patch diff -U 20 (obsolete) — Splinter Review
For whatever reason, themes/classic/communicator/communicator.css defines
    rules for .up, .up[disabled="true"], .down and .down[disabled="true"]
    twice, starting at line 62 first and line 80 second. The second bunch is
    apparently bogus, since it references the files scroll-up.gif,
    scroll-up-disabled.gif, scroll-down.gif, scroll-down-disabled.gif, which
    don't exist; and doesn't add anything else. Patch removes those lines, and
    lo, the arrows appear. :P

http://lxr.mozilla.org/seamonkey/source/themes/classic/communicator/communicator.css#62


    The nav>languages pref panel also regains the arrows on the "Move Up" and
    "Move Down" buttons.

    There are two inconsistencies: The mail>tools>filters dialog doesn't
    define the "up" and "down" class on similarly titled buttons, so no arrows
    there. Second, perhaps the mail>view>coding>customize dialog should have
    proper labels on the same buttons, in addition to the arrows. ...guess
    these are for another bug :)
->me
Assignee: shliang → t.bugz
Status: NEW → ASSIGNED
Attached patch diff -u (obsolete) — Splinter Review
feel free to r/sr/a/c
Keywords: patch, review
Blocks: 157067
Comment on attachment 91066 [details] [diff] [review]
diff -U 20

r=caillon
Attachment #91066 - Attachment is patch: true
Attachment #91066 - Flags: review+
We don't really want to REMOVE support for these arrows, we need to fix the
broken urls.  These arrows are now at chrome://global/skin/arrow/arrow-up.gif etc..
Attachment #91067 - Attachment is obsolete: true
yes. the patch does not touch the valid urls such as
("chrome://global/skin/arrow/arrow-up.gif", ...) that are already there, it only
removes the broken ones ("chrome://global/skin/scroll-up.gif, ...) overriding them.
i18n triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt3]
    The arrows are in place now; the dup lines specifying the bogus images
    were removed by 1.10 timeless%mozdev.org Nov 20 2002 Bug 171485 Remove
    duplicates in classic communicator.css patch by walk84@yahoo.com r=shuehan
    sr=bz

The "Move Up"/"Move Down" labels are still missing, though
Depends on: 171485
The buttons look as afaui they should in my tree; I haven't been around there
for ages, but I presume it's because of these changes. Someone might want to
verify that. This does make the labels longer, but I'd favor consistency with
other such lists (mail>tools>filters, edit>prefs>nav>history).
Attachment #91066 - Attachment is obsolete: true
s/history/languages/
Attachment #117136 - Flags: review?(sgehani)
Comment on attachment 117136 [details] [diff] [review]
patch to use labels and accesskeys, and add "Move " to the labels

r=sgehani
Attachment #117136 - Flags: review?(sgehani) → review+
Attachment #117136 - Flags: superreview?(jaggernaut)
Comment on attachment 117136 [details] [diff] [review]
patch to use labels and accesskeys, and add "Move " to the labels

Could you make the accesskeys be uppercase to match the case of the text?
They'll work as is, but first we do a case sensitive scan before doing a case
insensitive scan.

sr=jag, no new patch required
Attachment #117136 - Flags: superreview?(jaggernaut)
Attachment #117136 - Flags: superreview+
Attachment #117136 - Flags: approval1.4b?
Comment on attachment 117136 [details] [diff] [review]
patch to use labels and accesskeys, and add "Move " to the labels

a=asa (on behalf of drivers) for checkin to 1.4b
Attachment #117136 - Flags: approval1.4b? → approval1.4b+
with uppercase accesskeys per comment 16. jag, sgehani, will one of you check
this in for me?
Attachment #117136 - Attachment is obsolete: true
checked in by jag, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Keywords: classic
QA Contact: pmac → gbush
verified mac and linux - trunk builds before branch
Status: RESOLVED → VERIFIED
*** Bug 138641 has been marked as a duplicate of this bug. ***
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: