1395976 - Add more test cases in test_bbox-changes.xhtml

Status: NEW

(Core :: SVG, enhancement, P3)

Description

[u459114]

In bug 1361639, I change some logic in SVGTransformableElement::GetBBox to get correct bbox of an use element. Bug 1395873 was filed so I know that change cause some dead code.

I should also add more test cases in test_bbox-changes.xhtml to catch this mistake.

Comment 1

[u459114]

    if (flags == nsSVGUtils::eBBoxIncludeMarkers ||
        flags == nsSVGUtils::eBBoxIncludeClipped) {
      flags |= nsSVGUtils::eBBoxIncludeFill;
    }
The change in bug 1361639 will miss including eBBoxIncludeFill when the caller pass simple SVGBoundingBoxOptions::markers or SVGBoundingBoxOptions::clipped flag.

Comment 2

[u459114]

I think it should be better to comment what is the difference between "nsSVGUtils::eBBoxIncludeFill" and "nsSVGUtils::eBBoxIncludeFillGeometry", since I can not really understand it before reading a comment at [1]. (maybe copy concept from [1]?)

[1] https://hg.mozilla.org/mozilla-central/file/52d586efd12e/layout/svg/SVGGeometryFrame.cpp#l400