Open Bug 1395983 Opened 2 years ago Updated Last year

Ensure CustomizableUI does not save unnecessary state on new profiles

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

Tracking Status
firefox57 --- wontfix

People

(Reporter: Paolo, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should verify that the CustomizableUI module does not create any saved state on profiles that have not been customized by the user, which is the whole point of having lazy initialization of the customization state.
This seems to fail because hookDeveloperToggle calls CustomizableUI.createWidget:

https://dxr.mozilla.org/mozilla-central/rev/13d241d08912be31884f9d0d0e805b25343d6c0a/devtools/shim/devtools-startup.js#272
No longer blocks: 1387416
TBH, I think it's fine for there to be "seen" widgets, but the state of the navbar and other toolbars should not have been saved in this case. I didn't think we did save them if they matched the defaults, but maybe that's not actually what happens.
Tweaking the summary. I think this is worthwhile if we can basically drop area placements from being saved when they're at the default. We will likely need to remove support for persisted currentsets in that case (which we should do anyway). That way we can minimize the amount of data we store in the pref.
Summary: Ensure CustomizableUI does not save state on new profiles → Ensure CustomizableUI does not save unnecessary state on new profiles
Priority: -- → P5
This should be better after bug 1510321 lands.
Depends on: 1510321
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs (he/him) from comment #5)
> This should be better after bug 1510321 lands.

Nope. I still see it saving placements for every single area.
You need to log in before you can comment on or make changes to this bug.