139606 - Properties button in toolbar only enabled during download

Status: RESOLVED DUPLICATE of bug 474620

(SeaMonkey :: Download & File Handling, defect)

Description

[sairuh (rarely reading bugmail)]

when the dl mgr first landed, the Properties button in its toolbar wasn't hooked
up... i cannot seem to find an existing bug for this, so am filing this one.
seems like Properties is *always* disabled.

is this gonna be hooked up any time soon? or, should we just remove it?

Comment 1

[sairuh (rarely reading bugmail)]

recently tested using 2002.04.22.0x-1.0.0 commercial branch bits.

Comment 2

[Blake Ross]

works for me in 4/23 comm nightly 1.0, for items that are currently downloading...

Comment 3

[Samir Gehani]

Nav triage team: nsbeta1+, adt2

Comment 4

[Blake Ross]

need more info...

Comment 5

[sairuh (rarely reading bugmail)]

blake, does this work for you? because i don't think i've ever seen Properties
enabled on any platform...

or, does Properties only become enabled during certain cases, eg, when the file
is in the process of being downloaded, or finished downloading? (it hasn't
worked for me with the latter, which would be the most common case, methinks.)

Comment 6

[sairuh (rarely reading bugmail)]

i did more poking around (using today's branch bits), and it looks like
Properties is

a. only enabled *while* the file is being downloaded. it's not enabled after
download has completed. i re-read ben's spec, and couldn't find info as to
whether that's expected. (am guessing my slower connection at home is allowing
me to see this more easily than from the office.)

b. clicking on it currently just brings the regular download progress dialog to
the front. is that expected?

is (a) expected? why shouldn't this be enabled after download is completed?
should this be given to marlon/lori for recommendations?

feel free to downgrade as needed...

Comment 7

[Blake Ross]

It only works for items that are currently downloading, because it shows a
progress dialog.  This will change in the future but I think that's ok for rtm.

Comment 8

[Blake Ross]

<collided with you>

Yes, b is expected, but wouldn't normally happen once download manager appears
by default.

a is not ideal behavior, but okay for now.

Comment 9

[sairuh (rarely reading bugmail)]

okidoke --i'll let lori / marlon / adt reconsider whether (a) should be fixed soon.

resummarizing to clarify the actual issue am seeing.

Comment 10

[Peter Trudelle]

nsbeta1- per Nav triage team.

Comment 11

[jlarsen]

Note, when you press properties, and the download progress window comes up,
there is no way to get rid of this window, without canceling the download. This
is definatly not helpful.

Comment 12

[Aidas Kasparas]

Properties button should be enabled for downloads that were not finished for
whatever reason (interrupted by crash of mozilla, system shutdown, etc.). Or at
least there should be some way to get address of download. In the ideal world
"reload/ continue downloading" would be VERY helpfull.

Comment 13

[sairuh (rarely reading bugmail)]

nominating.

Comment 14

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 15

[Samir Gehani]

Over to Jan.

Comment 16

[Chris Petersen]

This issue is still occuring the Mach-0 (2003-01-23-07), OS 9 classic
(2003-01-22-13), and Win32 (2003-01-24-08) trunks builds.

Comment 17

[Christopher Hoess (gone)]

The behavior described in comment #11 is very annoying, FYI.

Comment 18

[Matthias Versen [:Matti]]

*** Bug 202746 has been marked as a duplicate of this bug. ***

Comment 19

[Jo Hermans]

*** Bug 207965 has been marked as a duplicate of this bug. ***

Comment 20

[Patrick Ogay]

Mozilla 1.3.1.
I wanted to "remove the downloaded" files from the list. 
Ctrl A, remove from List, didn't work.

I arrived to delete the single lines.
But a few entries are not deletable... don't know how to get rid of them. 

P. Ogay

Comment 21

[Andrew Schultz]

*** Bug 315270 has been marked as a duplicate of this bug. ***

Comment 22

[warren crossing]

The chrome change is easy
mozilla/chrome/comm.jar/components/communicator/downloadmanager/downloadmanger.js
line 182 - remove && isDownloading
http://bonsai.mozilla.org/rview.cgi?dir=mozilla/browser/components/downloads/src/Attic&cvsroot=/cvsroot&module=default
line 238 looks wrong - remove both lines, perhaps move them to RemoveDownload(&Path).

Comment 23

[Robert Kaiser]

The button is gone in the new download manager UI we have from SeaMonkey 2.0 Beta 1 upwards, but bug 474620 re-implements "properties" as a context and main menu item on the download manager and fixes this issue in being able to display the progress window for them even if the download is not active any more.