Closed Bug 1396205 Opened 7 years ago Closed 7 years ago

URL bar Go button jumps when starting to type something in a new tab

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR:

- open a new tab
- start typing

-> Go button jumps to the right because we hide the dropmarker

There are two easy ways to avoid this:

1) Reverse the position of the Go button and the dropmarker, or
2) Hide the Go button initially, only show it when the user started typing

I suggest we do the latter.
Attachment #8903878 - Flags: ui-review?(shorlander)
Priority: -- → P1
Comment on attachment 8903878 [details]
Bug 1396205 - Show the Go button only when the user started typing in the location bar. ui-r=shorlander

> 2) Hide the Go button initially, only show it when the user started typing

Agreed. Thank you!
Attachment #8903878 - Flags: ui-review?(shorlander) → ui-review+
Comment on attachment 8903878 [details]
Bug 1396205 - Show the Go button only when the user started typing in the location bar. ui-r=shorlander

https://reviewboard.mozilla.org/r/175660/#review182744

Looks good to me, cheers
Attachment #8903878 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c148323ff77
Show the Go button only when the user started typing in the location bar. ui-r=shorlander r=daleharvey
Backed out for timing out in browser/base/content/test/urlbar/browser_locationBarCommand.js and friends:

https://hg.mozilla.org/integration/autoland/rev/9451690a4f75eb55b391332ad7900e2484216848

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5c148323ff77d13366337adf2ae343c573624354&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=129533728&repo=autoland

[task 2017-09-08T12:03:35.612671Z] 12:03:35     INFO - TEST-START | browser/base/content/test/urlbar/browser_locationBarCommand.js
[task 2017-09-08T12:04:20.631888Z] 12:04:20     INFO - TEST-INFO | started process screentopng
[task 2017-09-08T12:04:22.318455Z] 12:04:22     INFO - TEST-INFO | screentopng: exit 0
[task 2017-09-08T12:04:22.324715Z] 12:04:22     INFO - Buffered messages logged at 12:03:35
[task 2017-09-08T12:04:22.324930Z] 12:04:22     INFO - Entering test bound setup
[task 2017-09-08T12:04:22.330172Z] 12:04:22     INFO - Leaving test bound setup
[task 2017-09-08T12:04:22.331381Z] 12:04:22     INFO - Entering test bound alt_left_click_test
[task 2017-09-08T12:04:22.339359Z] 12:04:22     INFO - Running test: Alt left click
[task 2017-09-08T12:04:22.347853Z] 12:04:22     INFO - TEST-PASS | browser/base/content/test/urlbar/browser_locationBarCommand.js | page proxy state must be invalid for go button to be visible - 
[task 2017-09-08T12:04:22.351201Z] 12:04:22     INFO - Buffered messages finished
[task 2017-09-08T12:04:22.357254Z] 12:04:22     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_locationBarCommand.js | Test timed out - 

TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_locationBarExternalLoad.js | Test timed out -
TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_locationBarExternalLoad.js | Found a tab after previous test timed out: about:blank -
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8616624d6d1c
Show the Go button only when the user started typing in the location bar. ui-r=shorlander r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/8616624d6d1c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug according to (2017-09-02)

Fixing bug is verified on Latest Beta--
Build ID    :20171016185129
User Agent  :Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0

Tested OS--Windows7 32bit
QA Whiteboard: [testday-20171013]
I reproduced this issue using Fx 57.0a1, build ID: 20170902220453, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 57.0b9, on Windows 10 x64, Ubuntu 16.04 LTS and mac OS X 10.12.
Status: RESOLVED → VERIFIED
Regressions: 1840827
You need to log in before you can comment on or make changes to this bug.