1396230 - Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList in PerformanceObserver::Notify()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

This is the reason why po-callback-mutate.any.js fails.

From the spec [1];

  1. Let entries be a copy of po’s observer buffer.
  2. Empty po’s observer buffer.
  3. If entries is non-empty, call po’s callback with entries as first
     argument and po as the second argument and callback this value. If this
     throws an exception, report the exception.

We need to clear the mQueuedEntries before calling callbacks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e17a1cdd53a53aaa4ee6bbd53fda8b70acb1ce

[1] https://w3c.github.io/performance-timeline/#queue-a-performanceentry

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1396230 - Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList.

This matches to the spec and makes po-callback-mutate.any.js test pass.

From the spec [1]

  1. Let entries be a copy of po’s observer buffer.
  2. Empty po’s observer buffer.
  3. If entries is non-empty, call po’s callback with entries as first
     argument and po as the second argument and callback this value. If this
     throws an exception, report the exception.

[1] https://w3c.github.io/performance-timeline/#queue-a-performanceentry

Review commit: https://reviewboard.mozilla.org/r/175684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175684/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8903905 [details]
Bug 1396230 - Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList.

https://reviewboard.mozilla.org/r/175684/#review181006

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f05955da7a2a
Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList. r=baku

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f05955da7a2a