Closed Bug 1396230 Opened 7 years ago Closed 7 years ago

Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList in PerformanceObserver::Notify()

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

()

Details

Attachments

(1 file)

This is the reason why po-callback-mutate.any.js fails.

From the spec [1];

  1. Let entries be a copy of po’s observer buffer.
  2. Empty po’s observer buffer.
  3. If entries is non-empty, call po’s callback with entries as first
     argument and po as the second argument and callback this value. If this
     throws an exception, report the exception.

We need to clear the mQueuedEntries before calling callbacks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e17a1cdd53a53aaa4ee6bbd53fda8b70acb1ce

[1] https://w3c.github.io/performance-timeline/#queue-a-performanceentry
Comment on attachment 8903905 [details]
Bug 1396230 - Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList.

https://reviewboard.mozilla.org/r/175684/#review181006
Attachment #8903905 - Flags: review?(amarchesini) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f05955da7a2a
Clear PerformanceObserver mQueuedEntries right after they were copied to PerformanceObserverEntryList. r=baku
https://hg.mozilla.org/mozilla-central/rev/f05955da7a2a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → hikezoe
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.