Let PerformanceObserver ride the trains

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: dmose, Assigned: hiro)

Tracking

({dev-doc-complete})

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1271487 +++

As per bug 1271487, this has been baking in Nightly since 49.  Chrome appears to have had it generally available since Chrome 52.  It'd be wonderful to get this to ride the trains (maybe even 56?), since it's in use in the wild now.  

I'm hoping to use the Google TTI polyfill as soon as I reasonably can, which requires this API, as well as the Long Tasks API https://github.com/GoogleChrome/tti-polyfill.
(Assignee)

Updated

2 years ago
Depends on: 1395832
(Assignee)

Updated

2 years ago
Depends on: 1396219
(Assignee)

Updated

2 years ago
Depends on: 1396227
(Assignee)

Updated

2 years ago
Depends on: 1396228
(Assignee)

Updated

2 years ago
Depends on: 1396230
(Assignee)

Comment 1

2 years ago
Note that there are still 4 failures in testing/web-platform/tests/performance-timeline/ but I think they don't stop shipping performance observer.  The four failures are;

1. po-observe.html (lack of navigation timing support: bug 1043083)
2. po-navigation.html (lack of navigation timing support: bug 1043083)
3. idlharness.html (toJSON support: bug 1375829)
4. case-sensitivity.any.js (no bug)

As for 4, the test case is supposed to be received resource entries in worker that the resource entries actually were loaded in window context.  It's not clear to me that we should include such entries in worker. But anyway, it's not related to performance observer.
Thank you so much for doing this. Would you mind sending an intent to ship?
(Assignee)

Comment 3

2 years ago
Sure, I am preparing it.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=63a407e4a688f275e1aea1cd7b88664a2502a72f

Now I am looking for the status for WebKit and Edge..
(Assignee)

Comment 5

2 years ago
Thanks! I found the WebKit status.
(Assignee)

Comment 6

2 years ago
Intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/ELX9G6OOAjw

The try in comment 3 has lots of oranges, but all of them are unrelated to PerformanceObserver.
Comment hidden (mozreview-request)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8904863 [details]
Bug 1386021 - Enable PerformanceObserver on all channels.

https://reviewboard.mozilla.org/r/176638/#review181640

::: dom/performance/tests/test_performance_observer.html:6
(Diff revision 1)
>  <!--
>    Any copyright is dedicated to the Public Domain.
>    http://creativecommons.org/publicdomain/zero/1.0/
>  -->
>  <!DOCTYPE html>
>  <meta charset=utf-8>

move this into <head>

::: dom/performance/tests/test_worker_observer.html:6
(Diff revision 1)
>  <!--
>    Any copyright is dedicated to the Public Domain.
>    http://creativecommons.org/publicdomain/zero/1.0/
>  -->
>  <!DOCTYPE html>
>  <meta charset=utf-8>

same here
Attachment #8904863 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 9

2 years ago
Thanks for the review!
Comment hidden (mozreview-request)

Comment 11

2 years ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d86c033299e
Enable PerformanceObserver on all channels. r=baku
https://hg.mozilla.org/mozilla-central/rev/9d86c033299e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → hikezoe
Depends on: 1397980
:hiro, thanks so much for making this happen, it's like we're getting an expected gift for 57!
Adding dev-doc-needed back, because the browser compatibility chart at the bottom of https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver needs to be updated, and I can't quite figure out what the correct syntax is expected to be.

Updated

2 years ago
Depends on: 1398477
I've removed all the experimental banners (since it is now enabled by default in two major browsers), and updated the support tables on all relevant pages:

https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver (and child pages)
https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserverEntryList (and child pages)

I've also removed it from the experimental features page:

https://developer.mozilla.org/en-US/Firefox/Experimental_features

And I've added a note to the Fx57 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/57#New_APIs

Let me know if that looks OK. Cheers!
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.