1396240 - accessibility and private browsing indicators overlap the edge of the window on Windows 7

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jim Mathies [:jimm]]

Attachment: indicators.jpg

See screenshot

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

From the looks of it, the title bar is less than 24px. Will need to confirm, but adding Amy with ni? to see what we can do on Win7.

Comment 2

[Amy Lee [:amylee] UX]

(In reply to Yura Zenevich [:yzen] from comment #1)
> From the looks of it, the title bar is less than 24px. Will need to confirm,
> but adding Amy with ni? to see what we can do on Win7.

Can we move the icons in to the tab bar under it?

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Amy Lee [:amylee] UX from comment #2)
> (In reply to Yura Zenevich [:yzen] from comment #1)
> > From the looks of it, the title bar is less than 24px. Will need to confirm,
> > but adding Amy with ni? to see what we can do on Win7.
> 
> Can we move the icons in to the tab bar under it?

I think this is possible, I'll take care of it then.

Comment 4

[Dão Gottwald [:dao]]

Fixed by backout.

Comment 6

[Clément Lefèvre]

Might be related to bug 1398746.

Comment 7

[Clément Lefèvre]

Attachment: Private browing sign and fullscreen button on OS X 10.9

After this bug got fixed and sign went back, I could see that the fullscreen button appear to be a lot lower than it should (it's actually lower than in normal windows), hence not vertically centered on the bar.
See the joined screenshot to have an overview.

In the meantime, private browsing sign and fullscreen button now looks very very close, is this normal? Same question for the private browing sign that takes the full height on compact density while it wasn't before if I remember correctly.

Screenshot was taken on OS X 10.9.

Comment 8

[Julien Wajsberg [:julienw]]

oops wrong bug sorry