1396525 - keaGroup and signatureScheme in SSLChannelInfo are not correct

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P2)

Description

[Franziskus Kiefer [:franziskus]]

After fixing bug 1304923 it seems that the channelInfo isn't always correct.

Going to https://timtaubert.de/ for example we get
> group 65537
> signature 0
which is wrong because it's ECDH and signature scheme 0 shouldn't happen at all.

Comment 1

[Phabricator Automation]

Comment on attachment 8904301 [details]
Bug 1396525 - Bug put keaGroup and sigScheme in the cache so we can put it in SSLChannelInfo, r=mt

Martin Thomson [:mt:] has approved the revision.

https://phabricator.services.mozilla.com/D29#1935

Comment 2

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/6fb9c5396d52e007c1cdc7330e062589478fdb5e

Comment 3

[Kai Engert [:KaiE:]]

This bug added an (allowed) ABI change.

We need to check in the ABI change report, to silence the automatic change reporting.

(You didn't hear from me earlier, because ABI reporting was broken, see bug 1410909.)

Comment 4

[Kai Engert [:KaiE:]]

Attachment: whitelist-abi-change-1396525.patch

Comment 5

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8921089 [details] [diff] [review]
whitelist-abi-change-1396525.patch

Review of attachment 8921089 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/4698be108cbc