1396584 - Remove support for multiple ShadowRoots

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d6dadf3b99d9ddf16896a4b333361bb9bf112bf

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_multiple_shadow.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/3de09b938bbcf52f77334f6996a99f1d100d76f2
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=3de09b938bbcf52f77334f6996a99f1d100d76f2
remote: recorded changegroup in replication log in 0.007s

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_shadow_parser.diff

(I don't know whether I can land this)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

looks like ./mach clang-format has changed some random things.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8905028 [details] [diff] [review]
remove_multiple_shadow.diff

But no, this isn't right yet.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8905029 [details] [diff] [review]
remove_shadow_parser.diff

No, this is still wrong. The documentation doesn't work when one wants to remove an element

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: parser bits

ok, one needs to remove the element name from ELEMENT_NAMES (which is generated java code!) before regenerating the java code. This all is bizarre ;)

Comment 8

[Henri Sivonen (:hsivonen)]

Comment on attachment 8905049 [details] [diff] [review]
parser bits

Review of attachment 8905049 [details] [diff] [review]:
-----------------------------------------------------------------

Despite formatting, I trust that this just removes the SHADOW static.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

How does one land patches to parser repo? Do you need to do it?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_multiple_shadow.diff

HTML parser bits are generated, and clang-format did some unexpected things there.

V1 Shadow DOM doesn't have <shadow>. This is a cleaned up version of a patch wchen wrote.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/45be63e91a01787e6dc5bc4540bd93371e33164a
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=45be63e91a01787e6dc5bc4540bd93371e33164a
remote: recorded changegroup in replication log in 0.016s

Comment 12

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8905080 [details] [diff] [review]
remove_multiple_shadow.diff

Review of attachment 8905080 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, need to remove HTMLShadowElement.h too.

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_multiple_shadow_2.diff

thanks, missed that file removal.

Comment 14

[Henri Sivonen (:hsivonen)]

(In reply to Olli Pettay [:smaug] from comment #9)
> How does one land patches to parser repo? Do you need to do it?

Your ssh key should work. Normal hg push.

Comment 15

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8905113 [details] [diff] [review]
remove_multiple_shadow_2.diff

Review of attachment 8905113 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry it took me so long to get to this.

::: parser/html/nsHtml5ElementName.h
@@ +149,1 @@
>      }

These two close braces are lined up oddly, so it seems like there might still be some indentation problems in this file.

Comment 16

[Olli Pettay [:smaug][[e-mail]]]

nsHtml5ElementName.h is a generated file.

Comment 17

[Olli Pettay [:smaug][[e-mail]]]

This should land after 57 branching.

Comment 18

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_multiple_shadow_3.diff (rebase)

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8d213d3265f
Remove support for multiple ShadowRoots, r=mrbkap

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e8d213d3265f