Closed Bug 1396584 Opened 2 years ago Closed 2 years ago

Remove support for multiple ShadowRoots

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files, 2 obsolete files)

No description provided.
Attached patch remove_multiple_shadow.diff (obsolete) — Splinter Review
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/3de09b938bbcf52f77334f6996a99f1d100d76f2
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=3de09b938bbcf52f77334f6996a99f1d100d76f2
remote: recorded changegroup in replication log in 0.007s
Attachment #8905028 - Flags: review?(mrbkap)
Attachment #8905028 - Flags: feedback?(jjong)
Attached patch remove_shadow_parser.diff (obsolete) — Splinter Review
(I don't know whether I can land this)
Attachment #8905029 - Flags: review?(hsivonen)
looks like ./mach clang-format has changed some random things.
Comment on attachment 8905028 [details] [diff] [review]
remove_multiple_shadow.diff

But no, this isn't right yet.
Attachment #8905028 - Flags: review?(mrbkap)
Attachment #8905028 - Flags: feedback?(jjong)
Comment on attachment 8905029 [details] [diff] [review]
remove_shadow_parser.diff

No, this is still wrong. The documentation doesn't work when one wants to remove an element
Attachment #8905029 - Flags: review?(hsivonen)
Attached patch parser bitsSplinter Review
ok, one needs to remove the element name from ELEMENT_NAMES (which is generated java code!) before regenerating the java code. This all is bizarre ;)
Attachment #8905049 - Flags: review?(hsivonen)
Comment on attachment 8905049 [details] [diff] [review]
parser bits

Review of attachment 8905049 [details] [diff] [review]:
-----------------------------------------------------------------

Despite formatting, I trust that this just removes the SHADOW static.
Attachment #8905049 - Flags: review?(hsivonen) → review+
How does one land patches to parser repo? Do you need to do it?
Flags: needinfo?(hsivonen)
HTML parser bits are generated, and clang-format did some unexpected things there.

V1 Shadow DOM doesn't have <shadow>. This is a cleaned up version of a patch wchen wrote.
Attachment #8905080 - Flags: review?(mrbkap)
Attachment #8905080 - Flags: feedback?(jjong)
remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/45be63e91a01787e6dc5bc4540bd93371e33164a
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=45be63e91a01787e6dc5bc4540bd93371e33164a
remote: recorded changegroup in replication log in 0.016s
Comment on attachment 8905080 [details] [diff] [review]
remove_multiple_shadow.diff

Review of attachment 8905080 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, need to remove HTMLShadowElement.h too.
Attachment #8905080 - Flags: feedback?(jjong) → feedback+
thanks, missed that file removal.
Attachment #8905028 - Attachment is obsolete: true
Attachment #8905029 - Attachment is obsolete: true
Attachment #8905113 - Flags: review?(mrbkap)
Attachment #8905080 - Flags: review?(mrbkap)
(In reply to Olli Pettay [:smaug] from comment #9)
> How does one land patches to parser repo? Do you need to do it?

Your ssh key should work. Normal hg push.
Flags: needinfo?(hsivonen)
Comment on attachment 8905113 [details] [diff] [review]
remove_multiple_shadow_2.diff

Review of attachment 8905113 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry it took me so long to get to this.

::: parser/html/nsHtml5ElementName.h
@@ +149,1 @@
>      }

These two close braces are lined up oddly, so it seems like there might still be some indentation problems in this file.
Attachment #8905113 - Flags: review?(mrbkap) → review+
nsHtml5ElementName.h is a generated file.
This should land after 57 branching.
Priority: -- → P2
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8d213d3265f
Remove support for multiple ShadowRoots, r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/e8d213d3265f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
No longer blocks: shadowdom-initial-release
You need to log in before you can comment on or make changes to this bug.