Closed Bug 1396588 Opened 4 years ago Closed 4 years ago

Canvas updates should be applied in transaction with layers-free

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

In layers-free mode, canvas uses the ImageBridge protocol to send updates to the compositor instead of using transactions. Unfortunately this breaks frame consistency and sites like google maps rely on layout and canvas updates that are made within the same spin of the event loop to be rendered in the same frame.
Priority: P3 → P2
Whiteboard: gfx-noted → [wr-mvp] gfx-noted
Blocks: 1403457
Gecko does not use ImageBridge protocol to send updates to the compositor in layer-free mode. PWebRenderBridge is used for normal canvas use case.
:nical, can we close the bug?
Flags: needinfo?(nical.bugzilla)
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> Gecko does not use ImageBridge protocol to send updates to the compositor in
> layer-free mode. PWebRenderBridge is used for normal canvas use case.

In layer free mode AsyncImagePipelineManager + PWebRenderBridg is used for canvas in layer-free mode. AsyncImagePipelineManager usage helps for WebRenderLayerManager::EndEmptyTransaction().
> :nical, can we close the bug?

Yes indeed.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(nical.bugzilla)
Resolution: --- → FIXED
Priority: P2 → --
Resolution: FIXED → WORKSFORME
Whiteboard: [wr-mvp] gfx-noted → gfx-noted
Assignee: nobody → nical.bugzilla
Resolution: WORKSFORME → FIXED
Priority: -- → P1
Whiteboard: gfx-noted → [wr-mvp] [gfx-noted]
You need to log in before you can comment on or make changes to this bug.