1396604 - Remove all "content notifications" code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Some time ago we ran a "content notifications" experiment. This allowed us to subscribe to feeds of "known providers" and notify the user whenever there's new content on a page they visit frequently.

This experiment is disabled for quite some time already. For new content discovery experiments we will probably use platform independent approaches - like pocket in activity stream. I think it's time to remove this code.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1396604 - Remove content notifications code.

Review commit: https://reviewboard.mozilla.org/r/176058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176058/

Comment 3

[Jan Henning [:JanH]]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review181210

::: commit-message-632e4:1
(Diff revision 1)
> +Bug 1396604 - Remove content notifications code. r?nechen,janh

What else I've found:

* moz.build
* https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/app/src/main/res/values/ids.xml#20
* maybe https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java#129 and https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java#161 (if the comment is still accurate)
* now unused strings in [android_strings.dtd / strings.xml.in](https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile*string+content+notif&redirect=false)

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review181696

::: commit-message-632e4:2
(Diff revision 1)
> +Bug 1396604 - Remove content notifications code. r?nechen,janh
> +

maybe remove those files https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build#641

I can't build this patch locally.
Is there anything I should do ?

I can't tell from the log :(

 1:18.34 Note: Some input files use or override a deprecated API.
 1:18.34 Note: Recompile with -Xlint:deprecation for details.
 1:18.34 Note: Some input files use unchecked or unsafe operations.
 1:18.34 Note: Recompile with -Xlint:unchecked for details.
 1:21.00 make[4]: *** [mobile/android/base/libs] Error 2
 1:21.00 make[3]: *** [libs] Error 2
 1:21.00 make[2]: *** [default] Error 2
 1:21.00 make[1]: *** [realbuild] Error 2
 1:21.00 make: *** [build] Error 2
 1:21.04 0 compiler warnings present.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

> Is there anything I should do ?

No, I need to fix the patch. I'll push an updated version in a second.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176058/diff/1-2/

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review181806

::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java:160
(Diff revision 2)
>          // We can launch this category from the the magnifying glass in the quick search bar.
>          if (res == R.xml.preferences_search) {
>              return R.id.pref_header_search;
>          }
>  
>          // Launched as action from content notifications.

This one, too.

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review182140

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176058/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebc53301e8df
Remove content notifications code. r=JanH,nechen

Comment 11

[Jan Henning [:JanH]]

Attachment: Bug 1396604 followup - Remove unused drawable resources.

Review commit: https://reviewboard.mozilla.org/r/177400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177400/

Comment 12

[Jan Henning [:JanH]]

Comment on attachment 8905605 [details]
Bug 1396604 followup - Remove unused drawable resources.

https://reviewboard.mozilla.org/r/177400/#review182406

Checked on DXR - these aren't referenced from Gecko code, only the content notifications Java code that's now gone.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb9842835b31
followup - Remove unused drawable resources. r=JanH

Comment 14

[Jan Henning [:JanH]]

Oh great, I've overlooked the lint error about the feed alarm receiver.

Comment 15

[Jan Henning [:JanH]]

Attachment: Bug 1396604 followup - Remove reference to former FeedAlarmReceiver to fix lint failure.

Review commit: https://reviewboard.mozilla.org/r/177404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177404/

Comment 16

[Jan Henning [:JanH]]

Comment on attachment 8905609 [details]
Bug 1396604 followup - Remove reference to former FeedAlarmReceiver to fix lint failure.

https://reviewboard.mozilla.org/r/177404/#review182414

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa9f9146b198
followup - Remove reference to former FeedAlarmReceiver to fix lint failure. r=JanH

Comment 18

[Sebastian Kaspari (:sebastian; :pocmo)]

Thanks Jan!

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ebc53301e8df
https://hg.mozilla.org/mozilla-central/rev/bb9842835b31
https://hg.mozilla.org/mozilla-central/rev/aa9f9146b198