Closed
Bug 1396604
Opened 7 years ago
Closed 7 years ago
Remove all "content notifications" code
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(3 files)
Some time ago we ran a "content notifications" experiment. This allowed us to subscribe to feeds of "known providers" and notify the user whenever there's new content on a page they visit frequently. This experiment is disabled for quite some time already. For new content discovery experiments we will probably use platform independent approaches - like pocket in activity stream. I think it's time to remove this code.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8904283 [details] Bug 1396604 - Remove content notifications code. https://reviewboard.mozilla.org/r/176058/#review181210 ::: commit-message-632e4:1 (Diff revision 1) > +Bug 1396604 - Remove content notifications code. r?nechen,janh What else I've found: * moz.build * https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/app/src/main/res/values/ids.xml#20 * maybe https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java#129 and https://dxr.mozilla.org/mozilla-central/rev/632e42dca494ec3d90b70325d9c359f80cb3f38a/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java#161 (if the comment is still accurate) * now unused strings in [android_strings.dtd / strings.xml.in](https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile*string+content+notif&redirect=false)
Attachment #8904283 -
Flags: review?(jh+bugzilla) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8904283 [details] Bug 1396604 - Remove content notifications code. https://reviewboard.mozilla.org/r/176058/#review181696 ::: commit-message-632e4:2 (Diff revision 1) > +Bug 1396604 - Remove content notifications code. r?nechen,janh > + maybe remove those files https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build#641 I can't build this patch locally. Is there anything I should do ? I can't tell from the log :( 1:18.34 Note: Some input files use or override a deprecated API. 1:18.34 Note: Recompile with -Xlint:deprecation for details. 1:18.34 Note: Some input files use unchecked or unsafe operations. 1:18.34 Note: Recompile with -Xlint:unchecked for details. 1:21.00 make[4]: *** [mobile/android/base/libs] Error 2 1:21.00 make[3]: *** [libs] Error 2 1:21.00 make[2]: *** [default] Error 2 1:21.00 make[1]: *** [realbuild] Error 2 1:21.00 make: *** [build] Error 2 1:21.04 0 compiler warnings present.
Assignee | ||
Comment 5•7 years ago
|
||
> Is there anything I should do ?
No, I need to fix the patch. I'll push an updated version in a second.
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8904283 [details] Bug 1396604 - Remove content notifications code. https://reviewboard.mozilla.org/r/176058/#review181806 ::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java:160 (Diff revision 2) > // We can launch this category from the the magnifying glass in the quick search bar. > if (res == R.xml.preferences_search) { > return R.id.pref_header_search; > } > > // Launched as action from content notifications. This one, too.
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8904283 [details] Bug 1396604 - Remove content notifications code. https://reviewboard.mozilla.org/r/176058/#review182140
Attachment #8904283 -
Flags: review?(cnevinchen) → review+
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by s.kaspari@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ebc53301e8df Remove content notifications code. r=JanH,nechen
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8905605 [details] Bug 1396604 followup - Remove unused drawable resources. https://reviewboard.mozilla.org/r/177400/#review182406 Checked on DXR - these aren't referenced from Gecko code, only the content notifications Java code that's now gone.
Attachment #8905605 -
Flags: review+
Comment 13•7 years ago
|
||
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/bb9842835b31 followup - Remove unused drawable resources. r=JanH
Comment 14•7 years ago
|
||
Oh great, I've overlooked the lint error about the feed alarm receiver.
Comment hidden (mozreview-request) |
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8905609 [details] Bug 1396604 followup - Remove reference to former FeedAlarmReceiver to fix lint failure. https://reviewboard.mozilla.org/r/177404/#review182414
Attachment #8905609 -
Flags: review+
Comment 17•7 years ago
|
||
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/aa9f9146b198 followup - Remove reference to former FeedAlarmReceiver to fix lint failure. r=JanH
Assignee | ||
Comment 18•7 years ago
|
||
Thanks Jan!
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ebc53301e8df https://hg.mozilla.org/mozilla-central/rev/bb9842835b31 https://hg.mozilla.org/mozilla-central/rev/aa9f9146b198
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•