Closed Bug 1396604 Opened 2 years ago Closed 2 years ago

Remove all "content notifications" code

Categories

(Firefox for Android :: General, enhancement)

All
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(3 files)

Some time ago we ran a "content notifications" experiment. This allowed us to subscribe to feeds of "known providers" and notify the user whenever there's new content on a page they visit frequently.

This experiment is disabled for quite some time already. For new content discovery experiments we will probably use platform independent approaches - like pocket in activity stream. I think it's time to remove this code.
Duplicate of this bug: 1393452
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review181696

::: commit-message-632e4:2
(Diff revision 1)
> +Bug 1396604 - Remove content notifications code. r?nechen,janh
> +

maybe remove those files https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build#641

I can't build this patch locally.
Is there anything I should do ?

I can't tell from the log :(

 1:18.34 Note: Some input files use or override a deprecated API.
 1:18.34 Note: Recompile with -Xlint:deprecation for details.
 1:18.34 Note: Some input files use unchecked or unsafe operations.
 1:18.34 Note: Recompile with -Xlint:unchecked for details.
 1:21.00 make[4]: *** [mobile/android/base/libs] Error 2
 1:21.00 make[3]: *** [libs] Error 2
 1:21.00 make[2]: *** [default] Error 2
 1:21.00 make[1]: *** [realbuild] Error 2
 1:21.00 make: *** [build] Error 2
 1:21.04 0 compiler warnings present.
> Is there anything I should do ?

No, I need to fix the patch. I'll push an updated version in a second.
Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review181806

::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java:160
(Diff revision 2)
>          // We can launch this category from the the magnifying glass in the quick search bar.
>          if (res == R.xml.preferences_search) {
>              return R.id.pref_header_search;
>          }
>  
>          // Launched as action from content notifications.

This one, too.
Comment on attachment 8904283 [details]
Bug 1396604 - Remove content notifications code.

https://reviewboard.mozilla.org/r/176058/#review182140
Attachment #8904283 - Flags: review?(cnevinchen) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ebc53301e8df
Remove content notifications code. r=JanH,nechen
Comment on attachment 8905605 [details]
Bug 1396604 followup - Remove unused drawable resources.

https://reviewboard.mozilla.org/r/177400/#review182406

Checked on DXR - these aren't referenced from Gecko code, only the content notifications Java code that's now gone.
Attachment #8905605 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/bb9842835b31
followup - Remove unused drawable resources. r=JanH
Oh great, I've overlooked the lint error about the feed alarm receiver.
Comment on attachment 8905609 [details]
Bug 1396604 followup - Remove reference to former FeedAlarmReceiver to fix lint failure.

https://reviewboard.mozilla.org/r/177404/#review182414
Attachment #8905609 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/aa9f9146b198
followup - Remove reference to former FeedAlarmReceiver to fix lint failure. r=JanH
Thanks Jan!
You need to log in before you can comment on or make changes to this bug.