1396761 - Add testcase for createElement rethrowing the exact exception that was thrown from the upgrade, in customize built-in case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

We should add test for createElement rethrowing the exact exception that was thrown from the upgrade (bug 1299363 comment 111).

Comment 1

[John Dai[:jdai]]

We have a test case for createElement which is a autonomous custom elements[1] rethrowing the exact exception. In this bug, we need to add a test case for createElement which is a built-in custom elements rethrowing the exact exception[2]. 

[1] http://searchfox.org/mozilla-central/rev/e5b13e6224dbe3182050cf442608c4cb6a8c5c55/testing/web-platform/tests/custom-elements/Document-createElement.html#305-328
[2] https://dom.spec.whatwg.org/#concept-create-element (Step 5.3)

Comment 2

[Boris Zbarsky [:bzbarsky]]

> We have a test case for createElement which is a autonomous custom elements[1] rethrowing the exact exception.

I don't understand how we're passing this test, given bug 1407669.  If I just copy the test code into a file, I get a very clear failure.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ah, we're passing because the test is totally busted.  See https://github.com/w3c/web-platform-tests/pull/7601 for the fix that just landed upstream...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

The relevant spec link is now https://dom.spec.whatwg.org/#concept-create-element 5.5.
And https://html.spec.whatwg.org/multipage/custom-elements.html#concept-upgrade-an-element

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: throw_builtin.diff

Modified the test above which was for the non-built-in case.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc4b83096613
add a testcase ensuring creating customized built-in elements rethrow the exception from the constructor, r=mrbkap

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cc4b83096613

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11617 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged