Closed Bug 1396761 Opened 2 years ago Closed Last year

Add testcase for createElement rethrowing the exact exception that was thrown from the upgrade, in customize built-in case

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jdai, Assigned: smaug)

References

Details

Attachments

(1 file)

We should add test for createElement rethrowing the exact exception that was thrown from the upgrade (bug 1299363 comment 111).
We have a test case for createElement which is a autonomous custom elements[1] rethrowing the exact exception. In this bug, we need to add a test case for createElement which is a built-in custom elements rethrowing the exact exception[2]. 

[1] http://searchfox.org/mozilla-central/rev/e5b13e6224dbe3182050cf442608c4cb6a8c5c55/testing/web-platform/tests/custom-elements/Document-createElement.html#305-328
[2] https://dom.spec.whatwg.org/#concept-create-element (Step 5.3)
Priority: -- → P2
> We have a test case for createElement which is a autonomous custom elements[1] rethrowing the exact exception.

I don't understand how we're passing this test, given bug 1407669.  If I just copy the test code into a file, I get a very clear failure.
Depends on: 1407669
Ah, we're passing because the test is totally busted.  See https://github.com/w3c/web-platform-tests/pull/7601 for the fix that just landed upstream...
Assignee: jdai → nobody
Summary: Add testcase for createElement rethrowing the exact exception that was thrown from the upgrade → Add testcase for createElement rethrowing the exact exception that was thrown from the upgrade, in customize built-in case
Modified the test above which was for the non-built-in case.
Assignee: nobody → bugs
Attachment #8986768 - Flags: review?(mrbkap)
Attachment #8986768 - Flags: review?(mrbkap) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc4b83096613
add a testcase ensuring creating customized built-in elements rethrow the exception from the constructor, r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/cc4b83096613
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11617 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.