Closed
Bug 1396767
Opened 7 years ago
Closed 7 years ago
MIPS: Fix MOVF in simulator
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: miran.karic, Assigned: miran.karic)
Details
Attachments
(1 file)
2.07 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.104 Safari/537.36 Steps to reproduce: When reading cc field for MOVF instruction, incorrect bits were accessed. This caused the test asm.js/testMathLib.js to fail. The uploaded patch fixes the problem with MOVF.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8904486 -
Flags: review?(lhansen)
Attachment #8904486 -
Flags: checkin?
Comment 2•7 years ago
|
||
Comment on attachment 8904486 [details] [diff] [review] 0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch Review of attachment 8904486 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable to me, though I haven't looked in detail (not enough of a MIPS expert :)
Attachment #8904486 -
Flags: review?(lhansen)
Attachment #8904486 -
Flags: review+
Attachment #8904486 -
Flags: checkin?
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → Other
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Lars T Hansen [:lth] from comment #2) > Comment on attachment 8904486 [details] [diff] [review] > 0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch > > Review of attachment 8904486 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks reasonable to me, though I haven't looked in detail (not enough of a > MIPS expert :) Thank you! Could you also assign this to me, not sure but maybe this is needed to land?
Comment 4•7 years ago
|
||
I *think* the checkin-needed should be enough but it won't hurt if you own the bug.
Assignee: nobody → miran.karic
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8bc120c1cd33 MIPS: Fix MOVF in simulator. r=lth
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8bc120c1cd33
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•