1396767 - MIPS: Fix MOVF in simulator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Miran Karic]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.104 Safari/537.36

Steps to reproduce:

When reading cc field for MOVF instruction, incorrect bits were accessed. This caused the test asm.js/testMathLib.js to fail. The uploaded patch fixes the problem with MOVF.

Comment 1

[Miran Karic]

Attachment: 0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch

Comment 2

[Lars T Hansen [:lth]]

Comment on attachment 8904486 [details] [diff] [review]
0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch

Review of attachment 8904486 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, though I haven't looked in detail (not enough of a MIPS expert :)

Comment 3

[Miran Karic]

(In reply to Lars T Hansen [:lth] from comment #2)
> Comment on attachment 8904486 [details] [diff] [review]
> 0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch
> 
> Review of attachment 8904486 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks reasonable to me, though I haven't looked in detail (not enough of a
> MIPS expert :)

Thank you! Could you also assign this to me, not sure but maybe this is needed to land?

Comment 4

[Lars T Hansen [:lth]]

I *think* the checkin-needed should be enough but it won't hurt if you own the bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bc120c1cd33
MIPS: Fix MOVF in simulator. r=lth

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8bc120c1cd33