Closed
Bug 1396907
Opened 9 years ago
Closed 8 years ago
Abstract a BaseAuthManager for dom/u2f and dom/webauthn
Categories
(Core :: DOM: Device Interfaces, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jcj, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webauthn] [webauthn-cleanup])
Attachments
(1 external file)
Tim points out in https://bugzilla.mozilla.org/show_bug.cgi?id=1245527#c20 referring to dom/u2f/U2FManager.cpp 's use of ListenForVisibilityEvents and StopListeningForVisibilityEvents similar to dom/webauthn/WebAuthnManager.cpp:
> We could share a lot of code like this if we had a BaseAuthManager (or the like)
> that would be the base for the {U2F,WebAuthn}Manager classes.
We should do that cleanup... sometime.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8935005 [details]
Bug 1396907 - Abstract a BaseAuthManager for dom/u2f and dom/webauthn r?jcj
J.C. Jones [:jcj] has approved the revision.
https://phabricator.services.mozilla.com/D323#7954
Attachment #8935005 -
Flags: review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6afaaa5f7e7c
Abstract a BaseAuthManager for dom/u2f and dom/webauthn r=jcj
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•