If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Get rid of GeckoAppShell.getLayerView

RESOLVED FIXED in Firefox 58

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
20 days ago
3 hours ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

Trunk
Firefox 58
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

4 days ago
mozreview-review
Comment on attachment 8910757 [details]
Bug 1396951 - 5. Remove getLayerView usage from Robocop code;

https://reviewboard.mozilla.org/r/182232/#review187560
Attachment #8910757 - Flags: review?(gbrown) → review+

Comment 8

4 days ago
mozreview-review
Comment on attachment 8910755 [details]
Bug 1396951 - 3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient;

https://reviewboard.mozilla.org/r/182228/#review187578
Attachment #8910755 - Flags: review?(rbarker) → review+

Comment 9

4 days ago
mozreview-review
Comment on attachment 8910754 [details]
Bug 1396951 - 2. Don't use getLayerView() in GeckoInputConnection;

https://reviewboard.mozilla.org/r/182226/#review187594

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java:365
(Diff revision 1)
>              mCursorAnchorInfoBuilder = new CursorAnchorInfo.Builder();
>          }
>          mCursorAnchorInfoBuilder.reset();
>  
>          // Calculate Gecko logical coords to screen coords
> -        final View v = getView();
> +        final GeckoView v = getView();

Use a more descriptive variable name: view.
Attachment #8910754 - Flags: review?(esawin) → review+
Comment on attachment 8910753 [details]
Bug 1396951 - 1. Add and use HapticFeedbackDelegate;

https://reviewboard.mozilla.org/r/182224/#review187698
Attachment #8910753 - Flags: review?(snorp) → review+
Comment on attachment 8910756 [details]
Bug 1396951 - 4. Pass in GeckoView instance when sending a11y event;

https://reviewboard.mozilla.org/r/182230/#review187700
Attachment #8910756 - Flags: review?(snorp) → review+
Comment on attachment 8910758 [details]
Bug 1396951 - 6. Remove setLayerView/getLayerView;

https://reviewboard.mozilla.org/r/182234/#review187702
Attachment #8910758 - Flags: review?(snorp) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 25

4 days ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e5ce5633017
1. Add and use HapticFeedbackDelegate; r=snorp
https://hg.mozilla.org/integration/autoland/rev/71134284dc36
2. Don't use getLayerView() in GeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/155c1005c388
3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e9bc6e08091b
4. Pass in GeckoView instance when sending a11y event; r=snorp
https://hg.mozilla.org/integration/autoland/rev/b5a88815b3a6
5. Remove getLayerView usage from Robocop code; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/0a367a71ca43
6. Remove setLayerView/getLayerView; r=snorp

Comment 26

4 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e5ce5633017
https://hg.mozilla.org/mozilla-central/rev/71134284dc36
https://hg.mozilla.org/mozilla-central/rev/155c1005c388
https://hg.mozilla.org/mozilla-central/rev/e9bc6e08091b
https://hg.mozilla.org/mozilla-central/rev/b5a88815b3a6
https://hg.mozilla.org/mozilla-central/rev/0a367a71ca43
Status: ASSIGNED → RESOLVED
Last Resolved: 4 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Backed out for frequently failing robocop's testSettingsPages:

https://hg.mozilla.org/mozilla-central/rev/2cd3752963fc8f24f7c202687eab55e83222f608
https://hg.mozilla.org/mozilla-central/rev/ee035fc58bfa813da94d31d22a701c63cc283390
https://hg.mozilla.org/mozilla-central/rev/c24ad4171417a4d7bb10381152432794b5e03acd
https://hg.mozilla.org/mozilla-central/rev/866ee4c0900f538827535cf97070530e499878c8
https://hg.mozilla.org/mozilla-central/rev/ee9bdc65d7720dedf6e284ab36d76817c6c88211
https://hg.mozilla.org/mozilla-central/rev/d464f77195576407e0e77b9fe48981af154abbd7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0a367a71ca4381367346f9d600472d80205e72e3
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=132656726&repo=autoland
> TEST-UNEXPECTED-FAIL | testSettingsPages | Exception caught - junit.framework.AssertionFailedError: View with id: '2131296519', resource name: 'layer_view' is not found!
Status: RESOLVED → REOPENED
status-firefox58: fixed → affected
Flags: needinfo?(nchen)
Resolution: FIXED → ---
Target Milestone: Firefox 58 → ---
Depends on: 1402245
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 days ago
Flags: needinfo?(nchen)

Comment 34

3 days ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa3c8eefecef
1. Add and use HapticFeedbackDelegate; r=snorp
https://hg.mozilla.org/integration/autoland/rev/a39d4bbc8306
2. Don't use getLayerView() in GeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/4791f0377e29
3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/1dd2fccf441f
4. Pass in GeckoView instance when sending a11y event; r=snorp
https://hg.mozilla.org/integration/autoland/rev/4a111afcd561
5. Remove getLayerView usage from Robocop code; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/4324d70a4fc5
6. Remove setLayerView/getLayerView; r=snorp
https://hg.mozilla.org/mozilla-central/rev/fa3c8eefecef
https://hg.mozilla.org/mozilla-central/rev/a39d4bbc8306
https://hg.mozilla.org/mozilla-central/rev/4791f0377e29
https://hg.mozilla.org/mozilla-central/rev/1dd2fccf441f
https://hg.mozilla.org/mozilla-central/rev/4a111afcd561
https://hg.mozilla.org/mozilla-central/rev/4324d70a4fc5
Status: REOPENED → RESOLVED
Last Resolved: 4 days ago2 days ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

Updated

2 days ago
Depends on: 1402594
status-firefox57: affected → ---
You need to log in before you can comment on or make changes to this bug.