Get rid of GeckoAppShell.getLayerView

RESOLVED FIXED in Firefox 58

Status

defect
RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Depends on 1 bug)

Trunk
mozilla58
All
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(6 attachments)

No description provided.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8910757 [details]
Bug 1396951 - 5. Remove getLayerView usage from Robocop code;

https://reviewboard.mozilla.org/r/182232/#review187560
Attachment #8910757 - Flags: review?(gbrown) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8910755 [details]
Bug 1396951 - 3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient;

https://reviewboard.mozilla.org/r/182228/#review187578
Attachment #8910755 - Flags: review?(rbarker) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8910754 [details]
Bug 1396951 - 2. Don't use getLayerView() in GeckoInputConnection;

https://reviewboard.mozilla.org/r/182226/#review187594

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java:365
(Diff revision 1)
>              mCursorAnchorInfoBuilder = new CursorAnchorInfo.Builder();
>          }
>          mCursorAnchorInfoBuilder.reset();
>  
>          // Calculate Gecko logical coords to screen coords
> -        final View v = getView();
> +        final GeckoView v = getView();

Use a more descriptive variable name: view.
Attachment #8910754 - Flags: review?(esawin) → review+
Comment on attachment 8910753 [details]
Bug 1396951 - 1. Add and use HapticFeedbackDelegate;

https://reviewboard.mozilla.org/r/182224/#review187698
Attachment #8910753 - Flags: review?(snorp) → review+
Comment on attachment 8910756 [details]
Bug 1396951 - 4. Pass in GeckoView instance when sending a11y event;

https://reviewboard.mozilla.org/r/182230/#review187700
Attachment #8910756 - Flags: review?(snorp) → review+
Comment on attachment 8910758 [details]
Bug 1396951 - 6. Remove setLayerView/getLayerView;

https://reviewboard.mozilla.org/r/182234/#review187702
Attachment #8910758 - Flags: review?(snorp) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 25

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e5ce5633017
1. Add and use HapticFeedbackDelegate; r=snorp
https://hg.mozilla.org/integration/autoland/rev/71134284dc36
2. Don't use getLayerView() in GeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/155c1005c388
3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e9bc6e08091b
4. Pass in GeckoView instance when sending a11y event; r=snorp
https://hg.mozilla.org/integration/autoland/rev/b5a88815b3a6
5. Remove getLayerView usage from Robocop code; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/0a367a71ca43
6. Remove setLayerView/getLayerView; r=snorp
Depends on: 1402245
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Flags: needinfo?(nchen)

Comment 34

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa3c8eefecef
1. Add and use HapticFeedbackDelegate; r=snorp
https://hg.mozilla.org/integration/autoland/rev/a39d4bbc8306
2. Don't use getLayerView() in GeckoInputConnection; r=esawin
https://hg.mozilla.org/integration/autoland/rev/4791f0377e29
3. Move GeckoAppShell.viewSizeChanged() to GeckoLayerClient; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/1dd2fccf441f
4. Pass in GeckoView instance when sending a11y event; r=snorp
https://hg.mozilla.org/integration/autoland/rev/4a111afcd561
5. Remove getLayerView usage from Robocop code; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/4324d70a4fc5
6. Remove setLayerView/getLayerView; r=snorp

Updated

6 months ago
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 58 → mozilla58
You need to log in before you can comment on or make changes to this bug.