1397054 - Don't assume the display list builder gets deleted every frame

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: builder-settings

With retained-dl, we're going to retain the display list builder between frames (since it owns the arena that the items are allocated into).

This patch changes it so we rely less on getting a new builder state each frame.

Comment 1

[Markus Stange [:mstange]]

Comment on attachment 8904764 [details] [diff] [review]
builder-settings

Review of attachment 8904764 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutUtils.cpp
@@ +3531,4 @@
>    if (aFlags & PaintFrameFlags::PAINT_IN_TRANSFORM) {
>      builder.SetInTransform(true);
> +  } else {
> +    builder.SetInTransform(false);

Wouldn't it be nicer if BeginFrame() reset all these flags?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/380200b5b5c0
Reset nsDisplayListBuilder state each frame so that we can use it multiple times. r=mstange

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/380200b5b5c0