Closed
Bug 1397056
Opened 7 years ago
Closed 7 years ago
Add some new functions to SmallPointerArray
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
2.04 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Just expanding the API a bit, since I needed to use SmallPointerArray more extensively with the retained-dl changes.
Attachment #8904766 -
Flags: review?(nfroyd)
Updated•7 years ago
|
Assignee: nobody → matt.woodrow
Updated•7 years ago
|
Attachment #8904766 -
Attachment is patch: true
Comment 1•7 years ago
|
||
Comment on attachment 8904766 [details] [diff] [review] small-pointer-array Review of attachment 8904766 [details] [diff] [review]: ----------------------------------------------------------------- These changes look fine. Some tests for said changes would be splendid.
Attachment #8904766 -
Flags: review?(nfroyd) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/371a03aa9b24 Add Contains and a return parameter to Remove for SmallPointerArray. r=froydnj
I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=130433188&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/9e7cdda04cbfc5d4dae19e071498d3351923196e
Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/04077d71603e Add Contains and a return parameter to Remove for SmallPointerArray. r=froydnj
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/04077d71603e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: needinfo?(matt.woodrow)
You need to log in
before you can comment on or make changes to this bug.
Description
•