1397056 - Add some new functions to SmallPointerArray

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: small-pointer-array

Just expanding the API a bit, since I needed to use SmallPointerArray more extensively with the retained-dl changes.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8904766 [details] [diff] [review]
small-pointer-array

Review of attachment 8904766 [details] [diff] [review]:
-----------------------------------------------------------------

These changes look fine.  Some tests for said changes would be splendid.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/371a03aa9b24
Add Contains and a return parameter to Remove for SmallPointerArray. r=froydnj

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=130433188&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e7cdda04cbfc5d4dae19e071498d3351923196e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04077d71603e
Add Contains and a return parameter to Remove for SmallPointerArray. r=froydnj

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04077d71603e