Remove moz-chunked-text support from XHR

RESOLVED FIXED in Firefox 58

Status

()

Core
DOM
RESOLVED FIXED
2 months ago
25 days ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks: 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla58
dev-doc-complete, site-compat
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

2 months ago
In bug 1335365 I introduced Telemetry::MOZ_CHUNKED_TEXT_IN_XHR to count how often moz-chunked-text type is used in XHR. The result is: 0.16% I would like to proceed with removing this non-spec feature.
(Assignee)

Updated

2 months ago
Summary: Remove moz-blob support from XHR → Remove moz-chunked-text support from XHR
(Assignee)

Comment 1

2 months ago
Created attachment 8904885 [details] [diff] [review]
moz_text.patch
Assignee: nobody → amarchesini
Attachment #8904885 - Flags: review?(bugs)
(Assignee)

Comment 2

2 months ago
Created attachment 8904886 [details] [diff] [review]
moz_text.patch
Attachment #8904885 - Attachment is obsolete: true
Attachment #8904885 - Flags: review?(bugs)
Attachment #8904886 - Flags: review?(bugs)

Comment 3

2 months ago
Comment on attachment 8904886 [details] [diff] [review]
moz_text.patch

Is domerr.msg ever localized? If it is, could you ask some l10n folks to approve this. (But I think it isn't localized).

And if we want to be super conservative for FF57, this could perhaps land after the branch date.
Attachment #8904886 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

2 months ago
Green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83377f20f8b02d994f47a56bc2ceb7562857f266&selectedJob=128876770

Please, land this patch when 57 is the new beta.
Keywords: checkin-needed
Whiteboard: to land when 57 is in beta
(Assignee)

Updated

2 months ago
Keywords: dev-doc-needed
(Assignee)

Comment 5

2 months ago
Created attachment 8905107 [details] [diff] [review]
moz_text.patch
Attachment #8904886 - Attachment is obsolete: true
(Assignee)

Comment 6

2 months ago
Created attachment 8905110 [details] [diff] [review]
moz_text.patch
Attachment #8905107 - Attachment is obsolete: true
(Assignee)

Comment 7

2 months ago
NI RyanVM to land this patch after 57.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed

Comment 8

2 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fb93fcf2b8e
Remove the support for moz-chunk-text type in XHR, r=smaug
OK then.
Flags: needinfo?(ryanvm)
Whiteboard: to land when 57 is in beta

Comment 10

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9fb93fcf2b8e
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Comment 11

2 months ago
Looks like this is related to bug 1120171, so marking it as such for posterity.
Blocks: 1120171
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/prefixed-xmlhttprequest-response-types-including-moz-blob-are-no-longer-supported/
Keywords: site-compat
I have documented this, by adding a note to the responseType page and removing the information about those values:

https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseType#Browser_compatibility

And by adding a note to the Fx58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#APIs_2

Let me know if that looks OK. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.