Closed Bug 1397151 Opened 2 years ago Closed 2 years ago

Remove moz-chunked-text support from XHR

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 3 obsolete files)

In bug 1335365 I introduced Telemetry::MOZ_CHUNKED_TEXT_IN_XHR to count how often moz-chunked-text type is used in XHR. The result is: 0.16% I would like to proceed with removing this non-spec feature.
Summary: Remove moz-blob support from XHR → Remove moz-chunked-text support from XHR
Attached patch moz_text.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8904885 - Flags: review?(bugs)
Attached patch moz_text.patch (obsolete) — Splinter Review
Attachment #8904885 - Attachment is obsolete: true
Attachment #8904885 - Flags: review?(bugs)
Attachment #8904886 - Flags: review?(bugs)
Comment on attachment 8904886 [details] [diff] [review]
moz_text.patch

Is domerr.msg ever localized? If it is, could you ask some l10n folks to approve this. (But I think it isn't localized).

And if we want to be super conservative for FF57, this could perhaps land after the branch date.
Attachment #8904886 - Flags: review?(bugs) → review+
Green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83377f20f8b02d994f47a56bc2ceb7562857f266&selectedJob=128876770

Please, land this patch when 57 is the new beta.
Keywords: checkin-needed
Whiteboard: to land when 57 is in beta
Keywords: dev-doc-needed
Attached patch moz_text.patch (obsolete) — Splinter Review
Attachment #8904886 - Attachment is obsolete: true
Attached patch moz_text.patchSplinter Review
Attachment #8905107 - Attachment is obsolete: true
NI RyanVM to land this patch after 57.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fb93fcf2b8e
Remove the support for moz-chunk-text type in XHR, r=smaug
OK then.
Flags: needinfo?(ryanvm)
Whiteboard: to land when 57 is in beta
https://hg.mozilla.org/mozilla-central/rev/9fb93fcf2b8e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Looks like this is related to bug 1120171, so marking it as such for posterity.
Blocks: 1120171
I have documented this, by adding a note to the responseType page and removing the information about those values:

https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseType#Browser_compatibility

And by adding a note to the Fx58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#APIs_2

Let me know if that looks OK. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.