1397236 - Bookmarks folder in Bookmarks Toolbar unexpectedly closes after adding bookmark from Star button

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: UX regression

The problem is only on Nightly57.0a1.
If Library toolbutton is removed from nav bar, no problem will occur.

Reproducible: always

Steps To Reproduce:
(preparation)
p-2. Enable Bookmarks Toolbar
p-3. Create bookmark folder in the toolbar

(step)
1. Restart Browser or Open new window
2. Open web page serchbar/locationbar/link (do not use bookmarks)
3. Add bookmark into the created folder in step p-3 from Star button
4. Click on the the created folder in step p-3
   --- observe the problem

(optionally, the problem persists)
5. Repeat step 2-4

Actual Results:
The folder pulldown menu opens as expected.
However, the folder pull down menu will close unexpectedly after a few seconds.

Expected Results:
Should not close.

Comment 1

[Alice0775 White]

More simple str 

> 3. Add bookmark into the created folder in step p-3 from Star button

3. Add bookmark from Star button or Ctrl+D

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

Review commit: https://reviewboard.mozilla.org/r/177192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177192/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8905393 [details]
Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

https://reviewboard.mozilla.org/r/177192/#review182272

LGTM.

::: browser/themes/shared/browser.inc.css
(Diff revision 1)
> -/* Library animation */
> -
> +/* Required for Library animation */
> +#navigator-toolbox {
> -#navigator-toolbox[animate] {
>    position: relative;
>  }
> -

Did you mean to remove the empty lines between these rules? Why?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8905393 [details]
Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

https://reviewboard.mozilla.org/r/177192/#review182272

> Did you mean to remove the empty lines between these rules? Why?

I thought it would show the association between the lines better. I'll undo the line removals.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8905393 [details]
Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177192/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fae43b4534c
Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1fae43b4534c

Comment 8

[Stefan [:StefanG_QA]]

I was able to reproduce this issue on the Nightly build	(20170906154646).

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 (20170915100121)

This issue is verified as fixed with the latest Nightly build on 9/15/2017.