Closed Bug 1397236 Opened 7 years ago Closed 7 years ago

Bookmarks folder in Bookmarks Toolbar unexpectedly closes after adding bookmark from Star button

Categories

(Firefox :: Toolbars and Customization, defect, P1)

57 Branch
Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + verified

People

(Reporter: alice0775, Assigned: jaws)

References

Details

(Keywords: regression, Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

[Tracking Requested - why for this release]: UX regression

The problem is only on Nightly57.0a1.
If Library toolbutton is removed from nav bar, no problem will occur.

Reproducible: always

Steps To Reproduce:
(preparation)
p-2. Enable Bookmarks Toolbar
p-3. Create bookmark folder in the toolbar

(step)
1. Restart Browser or Open new window
2. Open web page serchbar/locationbar/link (do not use bookmarks)
3. Add bookmark into the created folder in step p-3 from Star button
4. Click on the the created folder in step p-3
   --- observe the problem

(optionally, the problem persists)
5. Repeat step 2-4

Actual Results:
The folder pulldown menu opens as expected.
However, the folder pull down menu will close unexpectedly after a few seconds.

Expected Results:
Should not close.
More simple str 

> 3. Add bookmark into the created folder in step p-3 from Star button

3. Add bookmark from Star button or Ctrl+D
Summary: Bookmarks folder in Bookmarks Toolbar unexpectedly closes after adding bookmark in it → Bookmarks folder in Bookmarks Toolbar unexpectedly closes after adding bookmark from Star button
Blocks: 1384953
Keywords: regression
Whiteboard: [photon-structure] → [photon-animation][triage]
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8905393 - Attachment description: , and can instead always keep it as position:relative for the li → , and can instead always keep it as position:relative for the library animation.
Attachment #8905393 - Flags: review?(dao+bmo) → review?(gijskruitbosch+bugs)
Iteration: --- → 57.3 - Sep 19
Priority: P3 → P1
Comment on attachment 8905393 [details]
Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

https://reviewboard.mozilla.org/r/177192/#review182272

LGTM.

::: browser/themes/shared/browser.inc.css
(Diff revision 1)
> -/* Library animation */
> -
> +/* Required for Library animation */
> +#navigator-toolbox {
> -#navigator-toolbox[animate] {
>    position: relative;
>  }
> -

Did you mean to remove the empty lines between these rules? Why?
Attachment #8905393 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8905393 [details]
Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the li

https://reviewboard.mozilla.org/r/177192/#review182272

> Did you mean to remove the empty lines between these rules? Why?

I thought it would show the association between the lines better. I'll undo the line removals.
Attachment #8905393 - Attachment description: , and can instead always keep it as position:relative for the li → , and can instead always keep it as position:relative for the library animation.
Attachment #8905393 - Flags: review?(dao+bmo)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fae43b4534c
Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/1fae43b4534c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1398264
Depends on: 1398252
Flags: qe-verify? → qe-verify+
QA Contact: stefan.georgiev
I was able to reproduce this issue on the Nightly build	(20170906154646).

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 (20170915100121)

This issue is verified as fixed with the latest Nightly build on 9/15/2017.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.