139726 - Duplicate variable definition broken compilers other than gcc

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Jay Yan]

Please see this two function prototypes: (line 71 and 74)

 70   void InitButtonEvent(nsMouseEvent &aEvent, PRUint32 aMsg,
 71                        GdkEventButton *aEvent);
 72   void InitMouseScrollEvent(nsMouseScrollEvent &aEvent,
 73                             GdkEventScroll *aGdkEvent, PRUint32 aMsg);
 74   void InitKeyEvent(nsKeyEvent &aEvent, GdkEventKey *aEvent, PRUint32 aMsg);

"aEvent" is defined twice. I am using CC on Solaris, the building process stops 
becasue of it. other compilers can not compile it neither, I think

change the second "aEvent" into "aGdkEvent" can fix it. I will attach the patch.

Comment 1

[Jay Yan]

it is a gtk2 port bug. let me own it.

Comment 2

[Jay Yan]

Attachment: patch

change the the name of the duplicate variable. CC on solaris feel more
comfortable now.

Comment 3

[Pete Zha]

Comment on attachment 80760 [details] [diff] [review]
patch

r=pete.zha

Comment 4

[Jay Yan]

Chris: can you sr= it? 

Thanks

Jay

Comment 5

[jag (Peter Annema)]

Comment on attachment 80760 [details] [diff] [review]
patch

sr=jag

Comment 6

[Jay Yan]

checked in by Pete, thanks, Pete

Comment 7

[timeless]

vrfy fixed 1.10 <[e-mail]> 27 Apr 2002 02:41