1397627 - IPCBlobInputStream must be always async and non-blocking

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Andrea Marchesini [:baku]]

This will avoid doing I/O on main-thread.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - IPCBlobInputStream should not be seekable

Smaug, you have already seen this patch before.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 1 - IPCBlobInputStream should always be async

This patch has been reviewed by smaug for bug 1381465.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 3 - nsIAsyncFileMetadata

This patch has been already reviewed by asuth in bug 1381465

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 4 - Fetch and other APIs vs necko and the size of the stream

We should propagate the size of the stream (when known) into necko when calling ExplicitSetUploadStream() otherwise Available() will be used.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8905371 [details] [diff] [review]
part 2 - IPCBlobInputStream should not be seekable

Please comment here in the bug (and perhaps also in the commit message) _why_ IPCBlobInputStream shouldn't be seekable, or why we don't need this code anymore.
Totally not clear from this bug currently.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8905376 [details] [diff] [review]
part 4 - Fetch and other APIs vs necko and the size of the stream

I think I'd prefer that instead of passing -1, which has special meaning, something like UNKNOWN_BODY_SIZE.
So, please use InternalResponse::UNKNOWN_BODY_SIZE or add a new named constant and use that.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4f8fad33b2f
IPCBlobInputStream doesn't need to be seekable, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f77a81b06e43
IPCBlobInputStream should be always async, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/85b18b5a5e43
nsIAsyncFileMetadata interface, r=asuth
https://hg.mozilla.org/integration/mozilla-inbound/rev/6933c6396bda
Fetch API and other components should pass the length of the stream to necko when known, r=smaug

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4f8fad33b2f
https://hg.mozilla.org/mozilla-central/rev/f77a81b06e43
https://hg.mozilla.org/mozilla-central/rev/85b18b5a5e43
https://hg.mozilla.org/mozilla-central/rev/6933c6396bda

Comment 10

[Daniel Holbert [:dholbert]]

(tweaking dependency field to replace bug 1399215 with its dupe-target, bug 1398556)