Closed Bug 1397820 Opened 7 years ago Closed 1 year ago

[non-OOP] onBeforeLinkTraversal is not called for sidebar

Categories

(WebExtensions :: General, enhancement, P3)

Product:
WebExtensions
Component:
General
Version:
49 Branch
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mixedpuppy, Unassigned)

References

Details

Like bug 1392210, if a panel is placing a web page in an iframe, the link traversal is misbehaving.  bug 1392210 fixed it for remote frames, but different code paths are followed for non-remote. 

This one only affects the sidebar.  For non-remote, it seems we probably need to implement XULBrowserWindow for the xul wrapper on the extension sidebar.
Summary: [non-OOP] onBeforeLinkTraversal is not called for extension frames → [non-OOP] onBeforeLinkTraversal is not called for sidebar
A quick try on adding a XULBrowserWindow did not pan out.
Priority: -- → P2
Priority: P2 → P3
Product: Toolkit → WebExtensions
Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958
Component: Untriaged → General
Depends on: 1701668
Severity: normal → S3

Is this still relevant? (I don't think non-oop iframes are even a thing these days)

Flags: needinfo?(mixedpuppy)

bug 1701668 removed this API so I think this can be closed. Shane can correct me if I'm wrong.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.