1701668 - Remove nsIWebBrowserChrome3 interface

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Neil Deakin]

The SSB feature was removed by bug 1682593. This gives an opportunity to reduce and eliminate the nsIWebBrowserChrome3 interface:

• all of the implementations of shouldLoadURI and shouldLoadURIInThisProcess do nothing except return true.
• all of the implementations of onBeforeLinkTraversal do the same thing except ext-browser-content.js which checks the appTab state on the docshell instead. This appears to be so that links in sidebars open in new tabs (bug 1392210), but I think we can just use the group for this.

I think the patches here fix bug 1397820. My understanding is that the expected behaviour is that links to other domains from sidebars should open in a new tab, whether in the top-level frame in the sidebar or in subframes. This should also happen for pinned tabs (bug 1396988) but I don't fix that here.

Comment 1

[Neil Deakin]

Attachment: Bug 1701668, remove shouldLoadURI and shouldLoadURIInThisProcess methods now that all implementers return true, r=kmag

Comment 2

[Neil Deakin]

Attachment: Bug 1701668, remove onBeforeLinkTraversal implementations and handle links in docshell, r=kmag,mixedpuppy

This also fixes links in top or in-process subframes and out-of-process subframes in extensions sidebars and panels so that they open in new tabs.

Depends on D110101

Comment 3

[Neil Deakin]

Attachment: Bug 1701668, remove nsIWebBrowserChrome3 interface, r=kmag

Depends on D110102

Comment 4

[Neil Deakin]

Attachment: Bug 1701668, remove WebBrowserChromeChild actor, r=agi

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abf5af44055d
remove shouldLoadURI and shouldLoadURIInThisProcess methods now that all implementers return true, r=kmag
https://hg.mozilla.org/integration/autoland/rev/da0d62a0534b
remove onBeforeLinkTraversal implementations and handle links in docshell, r=kmag,mixedpuppy,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/de070731df26
remove nsIWebBrowserChrome3 interface, r=kmag
https://hg.mozilla.org/integration/autoland/rev/ad3936fb3593
remove WebBrowserChromeChild actor, r=agi

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/abf5af44055d
https://hg.mozilla.org/mozilla-central/rev/da0d62a0534b
https://hg.mozilla.org/mozilla-central/rev/de070731df26
https://hg.mozilla.org/mozilla-central/rev/ad3936fb3593