Closed Bug 1398087 Opened 6 years ago Closed 4 years ago

Take Screenshot should capture top-level browser context, not current context

Categories

(Remote Protocol :: Marionette, defect, P3)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect

Tracking

(firefox72 wontfix, firefox73 fixed, firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox72 --- wontfix
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: automatedtester, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=js], [wptsync upstream])

Attachments

(2 files)

Bug 1398087 - [marionette] Take Screenshot should always capture the top-level browser context.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1398087 - [wdspec] Added test to ensure that Take Screenshot always captures the top-level browsing context.
47 bytes, text/x-phabricator-request
Details | Review 
Can I pick up this bug?
Totally! Let me flag is as mentored so that we can handle it correctly.

I know that there is less info yet about what needs to be done. But I would like that you first check available resources yourself, similarly what you did on the other bug. But let me know if something is unclear. Thanks.
Mentor: hskupin
Whiteboard: [lang=js]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

My mistake, this is not a duplicate of
https://bugzilla.mozilla.org/show_bug.cgi?id=1385706 as that deals
with using the correct dimensions. Which browsing context is
selected is obviously a separate thing.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Priority: P2 → P3

This got accidentally fixed by bug 1559592 for Firefox 70. I just noticed that by working on bug 1606794.

What I would like to still do on this bug is to add a webdriver test which ensures that behavior.

Assignee: nobody → hskupin
Blocks: 1606794
Mentor: hskupin
Status: REOPENED → ASSIGNED
Depends on: 1559592
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bad6e6cd0e7
[marionette] Take Screenshot should always capture the top-level browser context. r=marionette-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/0b3ed98078e8
[wdspec] Added test to ensure that Take Screenshot always captures the top-level browsing context. r=webdriver-reviewers,ato

Somehow no PR for the upstream wpt repository has been created yet by the sync bot. James can you please have a look?

Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21071 for changes under testing/web-platform/tests
Whiteboard: [lang=js] → [lang=js], [wptsync upstream]

Expecting the sync bot to always create a PR within 1 minute of the push is very optimistic :)

Flags: needinfo?(james)
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged by moz-wptsync-bot

https://hg.mozilla.org/mozilla-central/rev/3bad6e6cd0e7
https://hg.mozilla.org/mozilla-central/rev/0b3ed98078e8

Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.