"Take Element Screenshot" no longer uses the element's browsing context
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox-esr68 unaffected, firefox71 wontfix, firefox72 wontfix, firefox73 fixed, firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox71 | --- | wontfix |
| firefox72 | --- | wontfix |
| firefox73 | --- | fixed |
| firefox74 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(3 files, 3 obsolete files)
Reported as: https://github.com/mozilla/geckodriver/issues/1666
This is most likely a regression from bug 1559592 when we moved to the Fission compatible drawSnapshot command. Maybe it just gets the wrong browsing context id, and as such captures the wrong area.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D58622
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D58623
|
|
Assignee | |
Comment 5•5 years ago
|
||
Missed to fix an import for the element_dimensions() helper. Here a new try build for wd2 jobs only:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4cdc9bfe0fbc724b0532bd1bf40c1195eab15e3
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d73cb1b0011d [marionette] Fixed WebDriver:TakeScreenshot to capture frame's content. r=marionette-reviewers,ato https://hg.mozilla.org/integration/autoland/rev/565340ce11e8 [wdspec] Add Element.screenshot() command to webdriver client. r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/b2b3f10527c3 [wdspec] Improve screenshot tests for checking the contents of frames. r=webdriver-reviewers,ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21049 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged by moz-wptsync-bot
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d73cb1b0011d
https://hg.mozilla.org/mozilla-central/rev/565340ce11e8
https://hg.mozilla.org/mozilla-central/rev/b2b3f10527c3
|
|
Assignee | |
Comment 11•5 years ago
|
||
Firefox 72 will be released tomorrow. As such there is no way to get it fixed for that release, and it will ride the trains. We surely will land it for the next 73 beta!
|
||
Updated•5 years ago
|
|
|
||
Comment 12•5 years ago
•
|
||
|
|
Assignee | |
Comment 13•5 years ago
|
||
The backout was required because the landed change isn't WebDriver compliant! Compared to Take Element Screenshot, which needs the specific browsing context the element lives in, Take Screenshot always has to use the top-level browsing context. See also bug 1398087.
|
|
Assignee | |
Comment 14•5 years ago
|
||
I will continue on this bug once a new webdriver test has been written for bug 1398087.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21065 for changes under testing/web-platform/tests
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21066 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/21066 * Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/P0NBDxx5TVSEhWrti3UsiQ)
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/21065 * Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/GTjdrXF3SAaETA8l7i0AeQ)
|
|
Assignee | |
Updated•5 years ago
|
Upstream PR merged by jgraham
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 21•5 years ago
|
||
|
|
Assignee | |
Comment 22•5 years ago
|
||
|
|
Assignee | |
Comment 23•5 years ago
|
||
Depends on D59148
|
|
Assignee | |
Comment 24•5 years ago
|
||
Depends on D59149
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 25•5 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b5606ee2560 [marionette] Fixed WebDriver:TakeScreenshot to capture frame's content. r=marionette-reviewers,ato https://hg.mozilla.org/integration/autoland/rev/963798d98540 [wdspec] Add Element.screenshot() command to webdriver client. r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/bca8017c8461 [wdspec] Improve screenshot tests for checking the contents of frames. r=webdriver-reviewers,ato
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/21066 * Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/JnfVuhzORLucfbqBOGa24Q)
|
||
Comment 27•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b5606ee2560
https://hg.mozilla.org/mozilla-central/rev/963798d98540
https://hg.mozilla.org/mozilla-central/rev/bca8017c8461
Upstream PR merged by moz-wptsync-bot
|
|
||
Updated•5 years ago
|
|
||
Comment 29•5 years ago
|
||
Is this something you wanted to uplift to Beta for Fx73?
|
|
Assignee | |
Comment 30•5 years ago
|
||
Yes, totally. Please uplift these test-only patch series to mozilla-beta.
|
|
Assignee | |
Comment 31•5 years ago
|
||
Please note that this might also need the patch on bug 1398087 to be uplifted first.
|
||
Comment 32•5 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/ee46d1a82439
https://hg.mozilla.org/releases/mozilla-beta/rev/630aa544b5cc
https://hg.mozilla.org/releases/mozilla-beta/rev/829b044e019f
|
||
Updated•2 years ago
|
Description
•