1398135 - [Bookmark Sidebar] The bookmark is not grayed out when you try to cut it the second time

Status: RESOLVED DUPLICATE of bug 1209518

(Toolkit :: Places, defect, P3)

Description

[Oana Botisan, Desktop QA]

[Affected versions]:
- Beta 55.ob7, Beta 56.0b10, RC 55.0.3, Latest Nightly 57

[Affected platforms]:
- Windows 10 x64, Ubuntu 16.04 x 64, Mac OS x 10.11

[Steps to reproduce]:
1. Activate the Bookmarks Sidebar
2. Right-click on a bookmark and select 'Cut'
3. Go to another folder and paste the bookmark.
4. Repeat steps 3 and 4 and observe the bookmark.

[Expected result]:
- The bookmark should be grayed out.

[Actual result]:
- The second time the bookmark is not grayed out.

[Regression range]:
- I managed to reproduce on older Nighlty, but I will come with more details about the regression when I managed to search for it better. 

[Additional notes]:
- It seems that this happens every two attempts (first time the bookmark is grayed out, the second time is not, the third time is grayed out, the forth time is not and so on).

Comment 1

[Ciprian Georgiu, Desktop QA]

I can reproduce this issue on Windows 7 x86.

Comment 2

[Mark Banner (:standard8)]

On the console I'm seeing:

JavaScript error: chrome://browser/content/places/treeView.js, line 186: Error: Removed node passed to _getRowForNode
JavaScript error: chrome://browser/content/places/controller.js, line 1772: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Removed node passed to _getRowForNode" {file: "chrome://browser/content/places/treeView.js" line: 186}]'[JavaScript Error: "Removed node passed to _getRowForNode" {file: "chrome://browser/content/places/treeView.js" line: 186}]' when calling method: [nsIController::doCommand]

It seems to happen regardless of if async transactions are enabled or not - so it is unlikely to be an issue from those.

It'd definitely be useful to get a regression range here.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d0ebcaa7efb5&tochange=dd6ec482a85d

Suspect: Bug 730340

Comment 4

[Mike Taylor [:miketaylr]]

Let's move the regression keyword since we've been shipping this since v15.

Comment 5

[Mark Banner (:standard8)]

The cause of this is the same as bug 1209518, which I fixed recently.