1209518 - The pasted bookmark keeps the styling of a cut one

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: bookmarks.gif

Reproducible on: Firefox 44.0a1, Firefox 43.0a2, Firefox 41.0.1 across all platforms

Preconditions: use a dirty profile with reasonable amount of browsing history and bookmarks.


STR
1.Launch Firefox.
2.Enable the Bookmarks Toolbar.
3.Right-click on one of the bookmarks displayed in the toolbar and select "Cut".
4.Right-click on bookmarks toolbar area and select “Paste”.
5.In some cases it might be necessary to repeat steps 3 and 4 in order to reproduce this issue.

ER
The pasted bookmark returns to the default styling.

AR
The pasted bookmark has a blurry styling as it would still be cut.


Additional notes:
- This issue is reproducible on Firefox 44.0a1 (2015-09-28), Firefox 43.0a2 (2015-09-29), Firefox 41.0.1 (20150928151607) on Windows 7 64-bit, Ubuntu 13.03 32-bit and Mac OS X 10.10.5
- This issue is also reproducible on Firefox 41 (20150917150946) and on Firefox 37.0a1 (2015-01-01)
- It is always reproducible at a second attempt.
- I am attaching a video recorded on Windows 7 64-bit where I captured this issue.

Comment 1

[Mark Banner (:standard8)]

This works for me on the latest nightly (61), although bug 1253624 is still an issue.

Can someone verify that please?

Comment 2

[Victor Carciu]

I am still able to reproduce the issue in Latest Firefox Nightly(61.0a1). I will attach a new video recorded on Windows 10x64.

Comment 3

[Victor Carciu]

Attachment: Video for FF Nightly(61)

Comment 5

[Mark Banner (:standard8)]

I think this was probably caused by bug 674486 based on blame.

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1209518 - Fix highlighting of cut bookmarks.

Change the ownership check to be a more reliable determination of if something is being cut.

Review commit: https://reviewboard.mozilla.org/r/245470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245470/

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8979287 [details]
Bug 1209518 - Fix highlighting of cut bookmarks.

https://reviewboard.mozilla.org/r/245470/#review251588

The real reason, I think, is that populateClipboard() checks this.cutNodes.length, but cut() sets this.cutNodes just after invoking it.
Anyway, I like your fix more!

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8979287 [details]
Bug 1209518 - Fix highlighting of cut bookmarks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245470/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc2b79a70a8c
Fix highlighting of cut bookmarks. r=mak

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cc2b79a70a8c

Comment 11

[Victor Carciu]

Verified as fixed in Firefox 62 using Windows 10x64. I will attach a postfix video.

Comment 12

[Victor Carciu]

Attachment: Postfix video